-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14_2_X] Update ecalMultiFitUncalibRecHit_cfi.py
parameters for CC
#46915
Conversation
A new Pull Request was created by @jking79 for CMSSW_14_2_X. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
please test |
assign alca |
type ecal |
backport of #46763 |
@jking79 I don't see the modifier you are talking about. Could you please point it out? In which release is that re-processing expected to be run? |
@perrotta PR 46914 and PR 46915 where made at the request of @mandrenguyen to extend the changes made in PR 46904 for CMSSW_14_0_X to CMSSW_14_1_X and CMSSW 14_2_X. The reprocessing will be done in CMSSW_14_0_X. This PR makes parameter changes for the ECAL CC time reconstruction. The special modifier mentioned is used to switch the ECAL time reconstruction to the CC time reconstruction. This modifier is not included in this PR. |
+1 Size: This PR adds an extra 16KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
Hi @perrotta the modifier is |
Thank you @thomreis |
+alca
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
ecalMultiFitUncalibRecHit_cfi.py
parameters for CC
backport of PR #46763 |
backport of #46763 |
+1 |
BackPort of PR #46763
This PR does not affect the default reconstruction. The changes made by this PR are only activated by a special modifier. This PR is needed for a reprocessing discussed with PPD.
Changed ourOfTimeThresholdGain61pEB and ourOfTimeThresholdGain61mEB parameters for CC reconstruction from 3.0 to 12.0 on lines 15 and 16 of RecoLocalCalo/EcalRecProducers/python/ecalMultiFitUncalibRecHit_cfi.py
PR description:
This change address discrepancy seen in JERSF for TeV jets.
PR validation:
This PR makes an adjustment to config parameters and does not touch the code.
Details are documented in: SupplementalMaterialPR46763.pdf