Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix replacing of split pixel clusters in DQM online clients after #46694 #46892

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 7, 2024

PR description:

After #46694 was integrated, several DQM online client started to fail (see e.g. here) with exceptions of the type:

----- Begin Fatal Exception 07-Dec-2024 03:14:55 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_15_0_X_2024-12-06-2300/src/DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py
Exception Message:
 unknown python problem occurred.
ValueError: Trying to override definition of siPixelClusters while it is used by the task InitialStepPreSplittingFromHLTTask
 new object defined in: /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02866/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2024-12-06-2300/src/RecoLocalTracker/SiPixelClusterizer/python/SiPixelClusterizer_cfi.py
 existing object defined in: /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02866/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2024-12-06-2300/src/RecoTracker/IterativeTracking/python/InitialStepPreSplitting_cff.py

At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02866/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2024-12-06-2300/src/FWCore/ParameterSet/python/Config.py(494): __setattr__
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02866/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2024-12-06-2300/src/FWCore/ParameterSet/python/Config.py(784): extend
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02866/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2024-12-06-2300/src/FWCore/ParameterSet/python/Config.py(761): load
  /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_15_0_X_2024-12-06-2300/src/DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py(225): <module>

----- End Fatal Exception -------------------------------------------------

PR validation:

Run successfully the whole battery of unit tests of the DQM/Integration package

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46892/42937

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2024

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2321e6/43307/summary.html
COMMIT: a4b939d
CMSSW: CMSSW_15_0_X_2024-12-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46892/43307/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
  • 9.09.0_Higgs200ChargedTaus/step3_Higgs200ChargedTaus.log
  • 1306.01306.0_SingleMuPt1_UP15/step3_SingleMuPt1_UP15.log
Expand to see more relval errors ...

RelVals-INPUT

  • 159.01159.01_HydjetQ_reminiaodPbPb2022_INPUT/step2_HydjetQ_reminiaodPbPb2022_INPUT.log
  • 2500.0242500.024_NANOmcUL18reMINI/step2_NANOmcUL18reMINI.log
  • 2500.0232500.023_NANOmcUL17reMINI/step2_NANOmcUL17reMINI.log
Expand to see more relval errors ...

AddOn Tests

UNKNOWN
UNKNOWN
UNKNOWN

@mmusich
Copy link
Contributor Author

mmusich commented Dec 8, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2321e6/43313/summary.html
COMMIT: a4b939d
CMSSW: CMSSW_15_0_X_2024-12-08-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46892/43313/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 471
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3509526
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Dec 8, 2024

urgent

  • fixes IB failures.

@cmsbuild cmsbuild added the urgent label Dec 8, 2024
@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 476537e into cms-sw:master Dec 9, 2024
11 checks passed
@mmusich mmusich deleted the mm_fix_clients_post-46694 branch December 9, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants