-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce High Granularity Tracker Alignment Prompt Calibration Loop for HLT alignment conditions #46888
Conversation
…ixelAliHLTHG*_cff
…mmusich with cms-merge-topic
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46888/42923 |
A new Pull Request was created by @phnattla for master. It involves the following packages:
@antoniovilela, @atpathak, @cmsbuild, @consuegs, @davidlange6, @fabiocos, @mandrenguyen, @perrotta, @rappoccio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 48KB to repository Comparison SummarySummary:
|
# ------------------------------------------------------------------------------ | ||
# configure a filter to run only on the events selected by TkAlZMuMu AlcaReco | ||
from HLTrigger.HLTfilters.hltHighLevel_cfi import * | ||
ALCARECOTkAlZMuMuFilterForSiPixelAliHLT = hltHighLevel.clone( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you think to clone them from triggerResultsFilterFromDB
, as modified for other AlCa filters in #46742? I understand that you probably don't plan to prescale further these paths, but I wonder if the same configurations could be used for all them. Unless there is a real advantage in cloning from hltHighLevel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment applies to the other similar instances in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this specific instance you have commented upon it's not possible to use triggerResultsFilterFromDB
because the filtering is not based on a path key retrieved from the event setup but rather on the name of the path pathALCARECOTkAlHLTTracksZMuMu
which is executed in the step before (the alcareco sample creation: this ensures that the producer is run only in presence of the right input set of tracks).
Elsewhere it might be possible to use it, but there is no advantage in doing so. The input HLT paths are actually already limited in rate (see CMSHLT-3404), thus prescaling is not desireable - we'll actually be statistically limited.
@perrotta thanks for the comment. Indeed @phnattla and I have discussed this topic before and we definitely want to do that. We have been targeting that development for a follow-up PR to come at a later time for the following reasons:
In case you insist with introducing a strawman workflow in this PR, I take note and will try to provide one (albeit not immediately) -- unless @phnattla wants to follow-up on that. |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The goal of this PR is to integrate a new High Granularity Tracker Alignment Prompt Calibration Loop using both MinumumBias and Z → µµ data ("HG Combined alignment), aiming to provide alignment conditions for the High Level Triggers (HLT).
This would help keeping the alignment conditions for the HLT up to date to help combat effects of radiations damage, which accumulate over the year (see e.g. here).
This development is co-authored by @mmusich
PR validation:
This PR has been validated using the recipe [*]. Results of this validation can be inspected on this website.
[*]
CC: @henriettepetersen @TomasKello