Do not use default-constructed PortableCollections #46876

fwyzard · 2024-12-05T08:43:13Z

PR description:

Do not use default-constructed PortableCollections and similar objects: these have a not well-defined semantics, especially if put into the Event.

PR validation:

The full release builds ~~and unit tests pass.~~

fwyzard · 2024-12-05T08:43:28Z

please test

cmsbuild · 2024-12-05T08:43:37Z

cms-bot internal usage

fwyzard · 2024-12-05T08:43:46Z

+heterogeneous

fwyzard · 2024-12-05T08:43:55Z

enable gpu

cmsbuild · 2024-12-05T08:45:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46876/42902

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToCluster.cc modified in PR(s): [RFC] Add tests and rudimentary protections for default-constructed PortableCollections #44844

cmsbuild · 2024-12-05T08:46:18Z

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

DataFormats/VertexSoA (reconstruction, heterogeneous)
EventFilter/HcalRawToDigi (reconstruction)
HeterogeneousCore/AlpakaTest (heterogeneous)
RecoLocalTracker/SiPixelClusterizer (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @abdoulline, @bsunanda, @dkotlins, @felicepantaleo, @ferencek, @gpetruc, @makortel, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-12-05T10:20:39Z

-1

Failed Tests: UnitTests GpuUnitTests
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f8fdc/43268/summary.html
COMMIT: e912911
CMSSW: CMSSW_15_0_X_2024-12-04-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46876/43268/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testHeterogeneousCoreAlpakaTestModulesCPU had ERRORS

GPU Unit Tests

I found 1 errors in the following unit tests:

---> test testHeterogeneousCoreAlpakaTestModulesCUDA had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
2022.000001 step 1
2022.002001 step 1
2023.002001 step 1
2024.000001 step 1
2024.101001 step 1
2024.202001 step 1
2024.303001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2957317
DQMHistoTests: Total failures: 441
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2956856
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 174 log files, 144 edm output root files, 39 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 53058
DQMHistoTests: Total failures: 32
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 53026
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 24 log files, 30 edm output root files, 7 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-12-05T11:35:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46876/42904

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelPhase2DigiToCluster.cc modified in PR(s): [RFC] Add tests and rudimentary protections for default-constructed PortableCollections #44844
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToCluster.cc modified in PR(s): [RFC] Add tests and rudimentary protections for default-constructed PortableCollections #44844

fwyzard · 2024-12-05T16:03:56Z

please test

cmsbuild · 2024-12-05T16:03:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46876/42913

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelPhase2DigiToCluster.cc modified in PR(s): [RFC] Add tests and rudimentary protections for default-constructed PortableCollections #44844
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToCluster.cc modified in PR(s): [RFC] Add tests and rudimentary protections for default-constructed PortableCollections #44844

fwyzard · 2024-12-05T16:04:02Z

+heterogeneous

cmsbuild · 2024-12-05T16:04:26Z

Pull request #46876 was updated. @jfernan2, @mandrenguyen can you please check and sign again.

cmsbuild · 2024-12-05T17:50:30Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f8fdc/43284/summary.html
COMMIT: 6d13038
CMSSW: CMSSW_15_0_X_2024-12-05-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46876/43284/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3494042
DQMHistoTests: Total failures: 491
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3493531
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: found differences in 1 / 44 workflows

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 53058
DQMHistoTests: Total failures: 82
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 52976
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 24 log files, 30 edm output root files, 7 DQM output files
TriggerResults: no differences found

jfernan2 · 2024-12-05T18:40:14Z

+1

cmsbuild · 2024-12-05T18:40:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-12-05T21:07:24Z

+1

cmsbuild added this to the CMSSW_15_0_X milestone Dec 5, 2024

cmsbuild added reconstruction-pending pending-signatures orp-pending tests-started code-checks-pending heterogeneous-pending trk labels Dec 5, 2024

cmsbuild added heterogeneous-approved and removed heterogeneous-pending labels Dec 5, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 5, 2024

cmsbuild added tests-rejected and removed tests-started labels Dec 5, 2024

fwyzard force-pushed the no_default_constructed_PortableCollections branch from e912911 to 2cd534d Compare December 5, 2024 11:31

cmsbuild added tests-pending code-checks-pending heterogeneous-pending and removed tests-rejected code-checks-approved heterogeneous-approved labels Dec 5, 2024

fwyzard mentioned this pull request Dec 5, 2024

Let edm::Wrapper<T> use the constructor T{kUninitialized} #46877

Merged

cmsbuild added tests-pending code-checks-pending heterogeneous-pending and removed tests-rejected code-checks-approved heterogeneous-approved labels Dec 5, 2024

cmsbuild added tests-started code-checks-approved heterogeneous-approved and removed tests-pending code-checks-pending heterogeneous-pending labels Dec 5, 2024

cmsbuild added tests-approved and removed tests-started labels Dec 5, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Dec 5, 2024

cmsbuild added orp-approved and removed orp-pending labels Dec 5, 2024

cmsbuild merged commit 567a8bc into cms-sw:master Dec 5, 2024
14 checks passed

cmsbuild mentioned this pull request Dec 8, 2024

[G4] Update Geant4 to version 11.3.0 cms-sw/cmsdist#9556

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not use default-constructed PortableCollections #46876

Do not use default-constructed PortableCollections #46876

fwyzard commented Dec 5, 2024 •

edited

Loading

fwyzard commented Dec 5, 2024

cmsbuild commented Dec 5, 2024 •

edited

Loading

fwyzard commented Dec 5, 2024

fwyzard commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

fwyzard commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

fwyzard commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

jfernan2 commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

mandrenguyen commented Dec 5, 2024

Do not use default-constructed PortableCollections #46876

Do not use default-constructed PortableCollections #46876

Conversation

fwyzard commented Dec 5, 2024 • edited Loading

PR description:

PR validation:

fwyzard commented Dec 5, 2024

cmsbuild commented Dec 5, 2024 • edited Loading

fwyzard commented Dec 5, 2024

fwyzard commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

Unit Tests

GPU Unit Tests

Comparison Summary

GPU Comparison Summary

cmsbuild commented Dec 5, 2024

fwyzard commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

fwyzard commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

Comparison Summary

GPU Comparison Summary

jfernan2 commented Dec 5, 2024

cmsbuild commented Dec 5, 2024

mandrenguyen commented Dec 5, 2024

fwyzard commented Dec 5, 2024 •

edited

Loading

cmsbuild commented Dec 5, 2024 •

edited

Loading