Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain the TriggerObject template constructors #46875

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 5, 2024

PR description:

Constrain the TriggerObject template constructors.

PR validation:

Full release builds and unit tests pass.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 5, 2024

The reason for this is that while looking into #44844 I got some strange compiler errors from GCC (not from clang) related to these template constructors.

Adding the constrains fixes them.

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 5, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • DataFormats/HLTReco (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d5d71/43267/summary.html
COMMIT: 9c90b8b
CMSSW: CMSSW_15_0_X_2024-12-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46875/43267/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
2022.000001 step 1
2022.002001 step 1
2023.002001 step 1
2024.000001 step 1
2024.101001 step 1
2024.202001 step 1
2024.303001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 26 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2957317
  • DQMHistoTests: Total failures: 1479
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2955818
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 174 log files, 144 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Dec 5, 2024

+hlt

  • failures in reco and DQM comparisons are spurious (associated to known instabilities)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c5dc5f7 into cms-sw:master Dec 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants