-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constrain the TriggerObject template constructors #46875
Constrain the TriggerObject template constructors #46875
Conversation
cms-bot internal usage |
The reason for this is that while looking into #44844 I got some strange compiler errors from GCC (not from clang) related to these template constructors. Adding the constrains fixes them. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46875/42901 |
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 20KB to repository Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+hlt
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Constrain the
TriggerObject
template constructors.PR validation:
Full release builds and unit tests pass.