Use #include <...> for external headers

[fwyzard]

PR description:

Use #include <...> instead of #include "..." for external headers.

PR validation:

Full release builds and unit tests pass.

[fwyzard]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46874/42900

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• DataFormats/Candidate (reconstruction)
• DataFormats/Math (reconstruction)
• FWCore/Utilities (core)

@Dr15Jones, @jfernan2, @makortel, @mandrenguyen, @smuzaffar can you please review it and eventually sign? Thanks.
@fabiocos, @felicepantaleo, @gpetruc, @makortel, @missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-95b236/43265/summary.html
COMMIT: 24e374e
CMSSW: CMSSW_15_0_X_2024-12-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46874/43265/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestFWCoreReflectionClassVersionUpdate had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
2022.000001 step 1
2022.002001 step 1
2023.002001 step 1
2024.000001 step 1
2024.101001 step 1
2024.202001 step 1
2024.303001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 30 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2957317
• DQMHistoTests: Total failures: 1879
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2955418
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 174 log files, 144 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[fwyzard]

The same unit test passes in a local working area:

Creating test log file logs/el8_amd64_gcc12/testing.log
Skip    0s ... FWCore/Utilities/typedefs_t (Disabled via BuildFile)
Pass    0s ... DataFormats/Math/DataFormatsDeltaR_t
Pass    0s ... DataFormats/Math/DataFormatsEta_t
Pass    0s ... DataFormats/Math/DataFormatsAsin_t
Pass    0s ... DataFormats/Math/DataFormatsMulSymMatrix_t
Pass    0s ... DataFormats/Math/DataFormatsProjectMatrix_t
Pass    0s ... DataFormats/Math/DataFormatsMatrices_t
Pass    0s ... DataFormats/Math/DataFormatsExtVec_t
Pass    0s ... DataFormats/Math/DataFormatsSign_t
Pass    0s ... DataFormats/Math/DataFormatsSSEVec_t
Pass    0s ... DataFormats/Math/DataFormatscrossV4_t
Pass    0s ... DataFormats/Math/testGraph
Pass    0s ... FWCore/Utilities/HRTime_t
Pass    0s ... FWCore/Utilities/testFWCoreUtilitiesCatch2
Pass    0s ... DataFormats/Math/testDataFormatsMathPacking
Pass    0s ... DataFormats/Math/testMathApproximations
Pass    0s ... FWCore/Utilities/RunningAverage_t
Pass    0s ... FWCore/Utilities/TestHelper_t_testAdler32
Pass    1s ... FWCore/Utilities/InputTag_t
Pass    1s ... FWCore/Utilities/TestHelper_t_testFriendlyNames
Pass    1s ... DataFormats/Math/DataFormatsFastMath_t
Pass    1s ... DataFormats/Candidate/testDataFormatsCandidate
Pass    2s ... DataFormats/Math/DataFormatsSimilarityFast_t
Pass    4s ... DataFormats/Math/DataFormatsSimilarity_t
Pass    5s ... DataFormats/Math/simpleCholeskyTest
Pass    6s ... DataFormats/Math/DFM_MathRepr
Pass    6s ... DataFormats/Math/DFM_Atan2
Pass    7s ... DataFormats/Math/DFM_Math
Pass    8s ... DataFormats/Math/CholeskyInvert_t
Pass    8s ... FWCore/Reflection/TestFWCoreReflectionDumpClassVersion
Pass    8s ... FWCore/Reflection/TestFWCoreReflectionCheckClassVersion
Pass   23s ... FWCore/Reflection/TestFWCoreReflectionClassVersionUpdate
Pass   24s ... FWCore/Utilities/testFWCoreUtilities
Pass   26s ... DataFormats/Math/CholeskyInvertOnGPU_t
Pass   33s ... DataFormats/Math/testMathApproxMath
Pass   63s ... DataFormats/Math/testAtan2FastMath
Pass  125s ... DataFormats/Math/testAtan2
Pass  125s ... DataFormats/Math/testAtan2VDT

[fwyzard]

please test

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-95b236/43278/summary.html
COMMIT: 24e374e
CMSSW: CMSSW_15_0_X_2024-12-05-0900/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46874/43278/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 60 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3494042
• DQMHistoTests: Total failures: 2310
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3491712
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 1 / 44 workflows

[jfernan2]

+1

[makortel]

Comparison differences are related to #46416 and #39803

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1