Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_2_X] Allow using fake pixels from the digi morphing algorithm as cluster seeds but drop them from final clusters #46847

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Dec 2, 2024

PR description:

Backport of #46813 to CMSSW_14_2_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

A new Pull Request was created by @ferencek for CMSSW_14_2_X.

It involves the following packages:

  • RecoLocalTracker/SiPixelClusterizer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dkotlins, @felicepantaleo, @ferencek, @gpetruc, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2024

cms-bot internal usage

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 3, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df83ad/43215/summary.html
COMMIT: ad18068
CMSSW: CMSSW_14_2_X_2024-12-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46847/43215/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 3, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b5f25d7 into cms-sw:CMSSW_14_2_X Dec 4, 2024
20 checks passed
@mmusich mmusich deleted the DropFakePixelsFromFinalClusters_from-CMSSW_14_2_0_pre4 branch January 8, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants