Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update offline data GT in autoCond - CMSSW_14_1_X #46832

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

perrotta
Copy link
Contributor

Update the offline data GT that needed to be fixed:

Online GTs were not updated, differently from what is done in the master version of this GT, so that the very same GTs used online during 2024 data taking are also kept in the CMSSW_14_1_X release that was used for them.

However, to avoid crashes in the unit tests because of the records that could be remover with that updated HLT GT, the commit 0f577af comments out the scal_dqm_sourceclient-live_cfg.py test from the ones run in the unit tests of DQM/Integration: as correctly reported in a comment here below, the SCAL FED has been removed from DAQ since the end of Run 2.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #46824

@perrotta
Copy link
Contributor Author

backport of #46824

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Nov 30, 2024
@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2024

A new Pull Request was created by @perrotta for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • DQM/Integration (dqm)

@antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @perrotta, @rseidita can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @batinkov, @fabiocos, @francescobrivio, @missirol, @mmusich, @rsreds, @threus, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-470c81/43167/summary.html
COMMIT: 0f577af
CMSSW: CMSSW_14_1_X_2024-11-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46832/43167/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565709
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565653
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

hi @perrotta I see some differences in this backport wrt to the master PR, namely these lines are not removed https://github.com/cms-sw/cmssw/pull/46831/files#diff-ec1da77008258e7499040359c39f5a38db8c257261af24e9450e68f263519158L34-L39 .Is this intended?

@antoniovagnerini
Copy link

hi @perrotta I see some differences in this backport wrt to the master PR, namely these lines are not removed https://github.com/cms-sw/cmssw/pull/46831/files#diff-ec1da77008258e7499040359c39f5a38db8c257261af24e9450e68f263519158L34-L39 .Is this intended?

Edit: I saw this is mentioned in the description above. I am just wondering since technically the PR is not identical to the master PR, whether this should not be named as a backport, but with a different title

@perrotta
Copy link
Contributor Author

perrotta commented Dec 5, 2024

hi @perrotta I see some differences in this backport wrt to the master PR, namely these lines are not removed https://github.com/cms-sw/cmssw/pull/46831/files#diff-ec1da77008258e7499040359c39f5a38db8c257261af24e9450e68f263519158L34-L39 .Is this intended?

Edit: I saw this is mentioned in the description above. I am just wondering since technically the PR is not identical to the master PR, whether this should not be named as a backport, but with a different title

Only the "backport" flag exists, and not the "partial backport" one: we should stick on it...
Whatever is here was also in the master version of this PR: we only avoided to backport the online 141X GTs of 2024 because the new ones were never actually used online in 2024: they are just developments for next year, worth being tested in the new releases but not necessarily in CMSSW_14_1_X.

@antoniovagnerini
Copy link

+1

@perrotta
Copy link
Contributor Author

perrotta commented Dec 6, 2024

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b78325a into cms-sw:CMSSW_14_1_X Dec 8, 2024
9 checks passed
@perrotta perrotta deleted the updateDataGtInAutocond_141X branch December 8, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants