-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update offline data GT in autoCond - CMSSW_14_1_X #46832
Update offline data GT in autoCond - CMSSW_14_1_X #46832
Conversation
backport of #46824 |
please test |
A new Pull Request was created by @perrotta for CMSSW_14_1_X. It involves the following packages:
@antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @perrotta, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
hi @perrotta I see some differences in this backport wrt to the master PR, namely these lines are not removed https://github.com/cms-sw/cmssw/pull/46831/files#diff-ec1da77008258e7499040359c39f5a38db8c257261af24e9450e68f263519158L34-L39 .Is this intended? |
Edit: I saw this is mentioned in the description above. I am just wondering since technically the PR is not identical to the master PR, whether this should not be named as a backport, but with a different title |
Only the "backport" flag exists, and not the "partial backport" one: we should stick on it... |
+1 |
+alca |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Update the offline data GT that needed to be fixed:
run3_data
: 141X_dataRun3_v5Online GTs were not updated, differently from what is done in the master version of this GT, so that the very same GTs used online during 2024 data taking are also kept in the CMSSW_14_1_X release that was used for them.
However, to avoid crashes in the unit tests because of the records that could be remover with that updated HLT GT, the commit 0f577af comments out the
scal_dqm_sourceclient-live_cfg.py
test from the ones run in the unit tests of DQM/Integration: as correctly reported in a comment here below, the SCAL FED has been removed from DAQ since the end of Run 2.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #46824