Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data GT in autoCond - CMSSW_14_2_X #46831

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

perrotta
Copy link
Contributor

Update online GTs in autoCond after the end of the 2024 data taking (to be used for tests and development):

Also the offline data GT needed to be fixed:

Moreover, to avoid crashes in the unit tests because of the removed (now unused) records in the HLT GT, the commit 6198154 comments out the scal_dqm_sourceclient-live_cfg.py test from the ones run in the unit tests of DQM/Integration: as correctly reported in a comment here below, the SCAL FED has been removed from DAQ since the end of Run 2.

PR validation:

The removal of the not-needed records from the HLT GT was verified online as documented in CMSALCAFAST-94
Tested also in master

Backport of #46824

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2024

A new Pull Request was created by @perrotta for CMSSW_14_2_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • DQM/Integration (dqm)

@antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @perrotta, @rseidita can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @batinkov, @fabiocos, @francescobrivio, @missirol, @mmusich, @rsreds, @threus, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor Author

backport of #46824

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c48288/43168/summary.html
COMMIT: bbe1664
CMSSW: CMSSW_14_2_X_2024-11-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46831/43168/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483722
  • DQMHistoTests: Total failures: 1595
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3482107
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@antoniovagnerini
Copy link

+1

@perrotta
Copy link
Contributor Author

perrotta commented Dec 6, 2024

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3b620d7 into cms-sw:CMSSW_14_2_X Dec 7, 2024
9 checks passed
@perrotta perrotta deleted the updateDataGtInAutocond_142X branch December 8, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants