Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeDxCalibration as SiStrip gains and fixes to the APV gain payload inspector #46826

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 29, 2024

PR description:

This PR adds a couple of utility commits:

PR validation:

Relies on the existing unit tests of the package

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CondCore/SiStripPlugins (db)
  • CondTools/SiStrip (db)

@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @VinInn, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6720cf/43150/summary.html
COMMIT: a3a383d
CMSSW: CMSSW_15_0_X_2024-11-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46826/43150/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

Comment on lines +62 to +63
file = cms.untracked.FileInPath('CalibTracker/SiStripCommon/data/SiStripDetInfo.dat'),
printDebug = cms.untracked.uint32(100)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be more correct:

Suggested change
file = cms.untracked.FileInPath('CalibTracker/SiStripCommon/data/SiStripDetInfo.dat'),
printDebug = cms.untracked.uint32(100)
file = 'CalibTracker/SiStripCommon/data/SiStripDetInfo.dat',
printDebug = 100

@perrotta
Copy link
Contributor

+db

  • Fine as such, just mentioned in comment a possible improvement

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c4b2e2f into cms-sw:master Nov 29, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_DeDxAsGains branch November 29, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants