-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeDxCalibration
as SiStrip
gains and fixes to the APV gain payload inspector
#46826
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46826/42837 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
|
file = cms.untracked.FileInPath('CalibTracker/SiStripCommon/data/SiStripDetInfo.dat'), | ||
printDebug = cms.untracked.uint32(100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be more correct:
file = cms.untracked.FileInPath('CalibTracker/SiStripCommon/data/SiStripDetInfo.dat'), | |
printDebug = cms.untracked.uint32(100) | |
file = 'CalibTracker/SiStripCommon/data/SiStripDetInfo.dat', | |
printDebug = 100 |
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds a couple of utility commits:
DeDexCalibration
calibration format (introduced at Add new dEdx calibration condition format #45024) as SiStrip APV GainsSiStripApvGain_PayloadInspector
.PR validation:
Relies on the existing unit tests of the package
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A