[14_2_X] TICLv5a : Improve skeleton linking and parameters tuning

[waredjeb]

This is a backport of #46539

This PR improves the current Skeleton Linking

• New Parameters: tuned parameters for hadronic reconstruction.

• Code refactoring: simply code by refactoring pieces

• Modified TICLGraph: modified logic for traversing the graph and build components

• Small changes to TICLDumper: allow to run TICLDumper with TICLv4. It will consume SuperClusters (new with TICLv5) only in TICLv5

New parameters have been included also at HLT

The performance against TICLv4 can be found in the DPS approval talk https://indico.cern.ch/event/1462666/contributions/6158255/attachments/2940573/5170734/TICLv5_DPS_version3.pdf

Should be tested with a .203 workflow

E.g.

test parameters:

    - workflow_opts= -w upgrade
    - workflow = 29896.203, 29691.203, 29691.204
    - enable = profiling, hlt_p2_timing

Edit 06/11/2024:

• hltTiclTracksterLinks_cfi and hltTiclTracksterLinksUnseeded_cfi, Both of them were Unseeded with no differences between them, for consistency I removed hltTiclTracksterLinksUnseeded_cfi fixing the Egamma sequence accordingly
• I 've added the L1Seeded module and sequence for the Recovery Tracksters, it is not used but I added it for consistency with hltTiclTracksterLinksL1Seeded_cfi

[cmsbuild]

A new Pull Request was created by @waredjeb for CMSSW_14_2_X.

It involves the following packages:

• HLTrigger/Configuration (hlt)
• RecoHGCal/TICL (reconstruction, upgrade)

@Martin-Grunewald, @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @apsallid, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @missirol, @mmusich, @rovere, @sameasy, @silviodonato, @sobhatta, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from TICLv5a : Improve skeleton linking and parameters tuning #46539

[cmsbuild]

cms-bot internal usage

[mmusich]

@waredjeb, can you clarify what's the purpose of the backport?

[mmusich]

test parameters:

• workflow_opts= -w upgrade
• workflow = 29896.203, 29691.203, 29691.204
• enable = hlt_p2_integration, hlt_p2_timing

[waredjeb]

@waredjeb, can you clarify what's the purpose of the backport?

Hi @mmusich

Yes. So, in 14_2_X we have a procModifier to enable TICLv5. TICLv5a completes the implementation of TICLv5 and provides the final version of TICLv5. It would be nice to have in 14_2_X release the final TICL version instead of having the "incomplete" one in 14_2_X and a "complete" one in 15_0_X.

[mmusich]

It would be nice to have in 14_2_X

is there any plan to use such feature in 14_2_0? Otherwise technically 14_2_X is closed for feature requests and only bug-fixes are acceptable.

[mmusich]

@cmsbuild, please test

[waredjeb]

It would be nice to have in 14_2_X

is there any plan to use such feature in 14_2_0? Otherwise technically 14_2_X is closed for feature requests and only bug-fixes are acceptable.

This is a bug-fix, the previous configuration was bugged because of tuning of the parameters done on a bugged geometry

[mmusich]

This is a bug-fix, the previous configuration was bugged because of tuning of the parameters done on a bugged geometry

from the description this PR is also a bug-fix, but it also contains new features.
Having said that the actual scope of the changes remains unclear to me.

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8e99e/43135/summary.html
COMMIT: d112936
CMSSW: CMSSW_14_2_X_2024-11-28-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46822/43135/install.sh to create a dev area with all the needed externals and cmssw changes.

• HLT P2 Timing: chart

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1423 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3800267
• DQMHistoTests: Total failures: 5515
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3794732
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 216 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: found differences in 1 / 47 workflows

[jfernan2]

+1

[mmusich]

+hlt

• verbatim backport of TICLv5a : Improve skeleton linking and parameters tuning #46539 to 14.2.X
• overall rationale for the backport remains unclear, see [14_2_X] TICLv5a : Improve skeleton linking and parameters tuning #46822 (comment), though it should not harm having this in 14.2.0.

[waredjeb]

This is a bug-fix, the previous configuration was bugged because of tuning of the parameters done on a bugged geometry

from the description this PR is also a bug-fix, but it also contains new features. Having said that the actual scope of the changes remains unclear to me.

Hi @mmusich, so if it is a problem merging the PR, I can close it and we will tell people to use TICLv5 only from 15_0_X.

[mmusich]

so if it is a problem merging the PR, I can close it and we will tell people to use TICLv5 only from 15_0_X.

it is not a problem. If it's convenient to have it in 14.2.0 let it be there (PS. the PR is already signed).

[mmusich]

backport of #46539

[mmusich]

type bug-fix

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1