Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Et distributions for BC & SC energy ECAL DQM plots [14_1_X] #46810

Open
wants to merge 1 commit into
base: CMSSW_14_1_X
Choose a base branch
from

Conversation

kyungminparkdrums
Copy link

PR description:

This PR adds the ECAL DQM plots for transverse energy of basic and superclusters (in Layout/04 Energy).

PR validation:

PR is validated by running the ECAL online DQM configuration and verifying the plots on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the backport to 14_1_X, which is currently in production. Master PR is made in #46809

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kyungminparkdrums for CMSSW_14_1_X.

It involves the following packages:

  • DQM/EcalMonitorTasks (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @rchatter, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2024

cms-bot internal usage

@kyungminparkdrums kyungminparkdrums changed the title Add Et distributions for BC & SC energy ECAL DQM plots Add Et distributions for BC & SC energy ECAL DQM plots [14_1_X] Nov 27, 2024
@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ea82e/43571/summary.html
COMMIT: 43c39f5
CMSSW: CMSSW_14_1_X_2024-12-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46810/43571/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 31 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565709
  • DQMHistoTests: Total failures: 1622
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3564067
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1152.106 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 22.162 KiB EcalBarrel/EBClusterTask
  • DQMHistoSizes: changed ( 1000.0,... ): 8.976 KiB EcalEndcap/EEClusterTask
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants