Hepmc3tog4, addind the codes that provide a possibility to transfer HepMC3Product from the GEN step to the SIM step #46797
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46797/42785 |
|
A new Pull Request was created by @mkirsano for master. It involves the following packages:
@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cmsbuild
added
simulation-pending
code-checks-pending
and removed
code-checks-approved
labels
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46797/42799 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46797/42800 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46797/42801 |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46797/42828 |
|
please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
+1 |
|
+1 |
| } | ||
| } | ||
| const HepMC3::GenParticle *ppointer = pitr.get(); | ||
| if (fLumiFilter && !fLumiFilter->isGoodForLumiMonitor(ppointer)) { // MK: this function is always true |
There was a problem hiding this comment.
Can you comment on the purpose of this? isGoodForLumiMonitor is indeed always true
There was a problem hiding this comment.
This comes from the class Generator, written by somebody else for HepMC, time ago. May be there is a possibility to provide another, non-trivial function for special cases?
There was a problem hiding this comment.
Yeah but it's ok to do that in another PR if you prefer
|
And I'd also suggest to expand the PR title to be a bit more descriptive, thanks! |
mkirsano
changed the title
|
+analysis |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This is a continuation of the work described in the issue #36662
The added code allows to transfer the HepMC3 event record to Sim and load particles in Geant4. It is NOT USED if HepMC record is produced in the Genarator part.
Two test configurations are added in Pythia8Interface/test