Fix off by 1 error in Multi5x5ClusterAlgo [14_2]

[Dr15Jones]

PR description:

This fixes an off by one error introduced in #46756

PR validation:

Added printout of Clusters in the changed module both before and after #46756 and found differences with hits in cluster. With this change the printouts now match the results of before the PR.

backport of #46787

[Dr15Jones]

please test

[cmsbuild]

A new Pull Request was created by @Dr15Jones for CMSSW_14_2_X.

It involves the following packages:

• RecoEcal/EgammaClusterAlgos (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@Prasant1993, @ReyerBand, @Sam-Harper, @a-kapoor, @afiqaize, @argiro, @jainshilpi, @lgray, @missirol, @ram1123, @rchatter, @sameasy, @sobhatta, @thomreis, @valsdav, @varuns23, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45ae8f/43065/summary.html
COMMIT: c930ed1
CMSSW: CMSSW_14_2_X_2024-11-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46796/43065/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3083 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 3105
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3480597
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 1 / 44 workflows

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

hold
It's not clear to me why we should add the bug fix to 14_2_X since we just completed data taking in that release.
Wouldn't that make data and MC inconsistent?

[cmsbuild]

Pull request has been put on hold by @mandrenguyen
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[Dr15Jones]

@mandrenguyen the bug was introduced to CMSSW_14_2 just before we switched to CMSSW_15 as the new development. So if 14_2 is ever used for anything it will have introduced a known bug.

[mandrenguyen]

@mandrenguyen the bug was introduced to CMSSW_14_2 just before we switched to CMSSW_15 as the new development. So if 14_2 is ever used for anything it will have introduced a known bug.

Oops sorry, i had 14_1_X and 14_2_X momentarily confused.

[mandrenguyen]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1