[CORE] py2/3 compatibility:drop use of __future__

[smuzaffar]

see #46762

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46769/42753

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/ParameterSet/python/Config.py modified in PR(s): faster edmConfigDump with --prune, also prunes unreferenced PSets #43276, Introduce vFloat and float types in ParameterSets #45216
  • File FWCore/ParameterSet/python/TreeCrawler.py modified in PR(s): [Py312] Move away from using imp python module #46707
  • File FWCore/ParameterSet/python/Types.py modified in PR(s): Introduce vFloat and float types in ParameterSets #45216
  • File FWCore/ParameterSet/python/VarParsing.py modified in PR(s): VarParsing: prevent TypeError for default of int/float/bool list #45640
  • File FWCore/ParameterSet/test/cmsconfig.py modified in PR(s): Introduce vFloat and float types in ParameterSets #45216
  • File FWCore/Services/scripts/edmTracerCompactLogViewer.py modified in PR(s): Choose data to display for the Tracer Log Viewer #45483

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• DataFormats/FWLite (core)
• Documentation/DataFormats (core)
• Documentation/ReferenceManualScripts (core)
• FWCore/Concurrency (core)
• FWCore/Framework (core)
• FWCore/Integration (core)
• FWCore/MessageLogger (core)
• FWCore/Modules (core)
• FWCore/ParameterSet (core)
• FWCore/PythonUtilities (core)
• FWCore/Services (core)
• FWCore/Skeletons (core)
• FWCore/Utilities (core)
• IOMC/Input (core)
• IOMC/RandomEngine (core)
• Utilities/ReleaseScripts (core)
• Utilities/StaticAnalyzers (core)
• Validation/Performance (core)
• Validation/Tools (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@fabiocos, @felicepantaleo, @fwyzard, @makortel, @missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 488KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d1afd/43016/summary.html
COMMIT: 4759e53
CMSSW: CMSSW_14_2_X_2024-11-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46769/43016/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 2024.2020012024.202001_RunJetMET02024D_10k/step1_dasquery.log
• 2024.202001``````
• 2024.3030012024.303001_RunDisplacedJet2024E_10k/step1_dasquery.log

Expand to see more relval errors ...

• 2024.303001
• 2024.202001
• 2024.303001

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d1afd/43075/summary.html
COMMIT: 4759e53
CMSSW: CMSSW_15_0_X_2024-11-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46769/43075/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test TestDQMOnlineClient-visualization_secondInstance had ERRORS
---> test TestDQMOfflineConfigurationGotAll had ERRORS

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 497
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3483205
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[makortel]

The TestDQMOfflineConfigurationGotAll failed with

+ echo 'Final DQMOfflineConfiguration should not run any sequences.'
Final DQMOfflineConfiguration should not run any sequences.
+ echo 'Please update parameters for TestDQMOfflineConfiguration unittest to run the extra sequences.'
Please update parameters for TestDQMOfflineConfiguration unittest to run the extra sequences.

The cause is not immediately clear to me

[iarspider]

TestDQMOfflineConfigurationGotAll

#46791

[makortel]

@cmsbuild, please test

Let's see if we have better luck this time

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d1afd/43087/summary.html
COMMIT: 4759e53
CMSSW: CMSSW_15_0_X_2024-11-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46769/43087/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 494
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3483208
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1