[DQM] py2/3 compatibility:drop use of future #46767

smuzaffar · 2024-11-22T17:17:09Z

see #46762

cmsbuild · 2024-11-22T17:17:38Z

cms-bot internal usage

cmsbuild · 2024-11-22T17:23:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46767/42751

There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/Integration/python/clients/beam_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/beamfake_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/beampixel_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/csc_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1t_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1temulator_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1tstage1_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/l1tstage1emulator_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/physics_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/pixellumi_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/sistrip_approx_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
- File DQMServices/Components/scripts/dqmiolistmes.py modified in PR(s): Implement TH2Poly in DQM Services for HGCal DQM #41932
- File Validation/HGCalValidation/scripts/makeHGCalValidationPlots.py modified in PR(s): Improve TICL Association Map and update TICL event content #46700
- File Validation/RecoTrack/python/TrackValidation_cff.py modified in PR(s): Allowing Cluster Splitting with HLT Vertices #46694

cmsbuild · 2024-11-22T17:24:08Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

DPGAnalysis/HcalTools (dqm)
DQM/CSCMonitorModule (dqm)
DQM/DTMonitorModule (dqm)
DQM/Integration (dqm)
DQM/L1TMonitor (dqm)
DQM/MuonMonitor (dqm)
DQM/SiStripMonitorClient (dqm)
DQM/SiStripMonitorHardware (dqm)
DQM/SiStripMonitorSummary (dqm)
DQM/TrackerCommon (dqm)
DQM/TrackerRemapper (dqm)
DQMOffline/Alignment (dqm)
DQMOffline/CalibCalo (dqm)
DQMOffline/CalibTracker (dqm)
DQMOffline/Configuration (dqm)
DQMOffline/EGamma (dqm)
DQMOffline/JetMET (dqm)
DQMOffline/Trigger (dqm)
DQMServices/Components (dqm)
DQMServices/FileIO (dqm)
DQMServices/FwkIO (dqm)
DQMServices/StreamerIO (dqm)
HLTriggerOffline/Btag (dqm)
HLTriggerOffline/Common (dqm)
HLTriggerOffline/Egamma (dqm)
HLTriggerOffline/Exotica (dqm)
HLTriggerOffline/HeavyFlavor (dqm)
HLTriggerOffline/Muon (dqm)
Utilities/RelMon (dqm)
Validation/CaloTowers (dqm)
Validation/HGCalValidation (dqm)
Validation/HcalDigis (dqm)
Validation/RecoB (dqm)
Validation/RecoEgamma (dqm)
Validation/RecoMuon (dqm)
Validation/RecoParticleFlow (dqm)
Validation/RecoTau (dqm)
Validation/RecoTrack (dqm)
Validation/RecoVertex (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@AlexDeMoor, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Ming-Yan, @ReyerBand, @Senphy, @VinInn, @VourMa, @abbiendi, @abdoulline, @ahinzmann, @andrea21z, @andrzejnovak, @apsallid, @arossi83, @barvic, @batinkov, @battibass, @bsunanda, @calderona, @castaned, @cericeci, @cseez, @dgulhan, @fabiocos, @felicepantaleo, @fioriNTU, @francescobrivio, @gkasieczka, @hatakeyamak, @idebruyn, @jandrea, @jdamgov, @jdolen, @jhgoh, @lecriste, @lgray, @mariadalfonso, @missirol, @mmarionncern, @mmusich, @mtosi, @nhanvtran, @pfs, @ptcox, @rappoccio, @rociovilar, @rovere, @schoef, @seemasharmafnal, @sethzenz, @sroychow, @thomreis, @threus, @trocino, @vandreev11, @venturia, @wang0jin, @wddgit, @wmtford, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2024-11-25T07:21:54Z

please test

cmsbuild · 2024-11-25T09:17:35Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4307bb/43043/summary.html
COMMIT: e462f8e
CMSSW: CMSSW_15_0_X_2024-11-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46767/43043/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMOfflineConfigurationGotAll had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 303 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3596288
DQMHistoTests: Total failures: 3780
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3592488
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

antoniovagnerini · 2024-11-25T11:18:16Z

please test

antoniovagnerini · 2024-11-25T11:20:55Z

please abort

smuzaffar · 2024-11-25T11:21:13Z

@antoniovagnerini , TestDQMOfflineConfigurationGotAll tests is failing in IBs . #46791 should fix that unit test. Running tests for this PR without #46791 will still cause TestDQMOfflineConfigurationGotAll to fail

antoniovagnerini · 2024-11-25T11:22:23Z

yes this is why I aborted and was going to resubmit the tests in conjuction with #46791

antoniovagnerini · 2024-11-25T11:22:46Z

please test with #46791

cmsbuild · 2024-11-25T13:14:44Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4307bb/43052/summary.html
COMMIT: e462f8e
CMSSW: CMSSW_15_0_X_2024-11-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46767/43052/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 32 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3596288
DQMHistoTests: Total failures: 1863
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3594405
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 206 log files, 177 edm output root files, 47 DQM output files
TriggerResults: no differences found

antoniovagnerini · 2024-11-25T16:01:46Z

+1

cmsbuild · 2024-11-25T16:02:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #46791

mandrenguyen · 2024-11-25T18:02:52Z

+1

[DQM] py2/3 compatibility:drop use of __future__

e462f8e

cmsbuild added this to the CMSSW_15_0_X milestone Nov 22, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending tracking trk labels Nov 22, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 22, 2024

cmsbuild added tests-started and removed tests-pending labels Nov 25, 2024

cmsbuild added tests-rejected and removed tests-started labels Nov 25, 2024

cmsbuild added tests-started and removed tests-rejected labels Nov 25, 2024

cmsbuild added tests-pending and removed tests-started labels Nov 25, 2024

cmsbuild removed the tests-pending label Nov 25, 2024

cmsbuild added tests-started requires-external labels Nov 25, 2024

cmsbuild added tests-approved and removed tests-started labels Nov 25, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Nov 25, 2024

cmsbuild mentioned this pull request Nov 25, 2024

Fix DQM config test: Increase number of sequences to process #46791

Merged

cmsbuild added orp-approved and removed orp-pending labels Nov 25, 2024

cmsbuild merged commit 7d46987 into cms-sw:master Nov 25, 2024
11 checks passed

cmsbuild mentioned this pull request Nov 25, 2024

enable --as-needed flag for scram projects cms-sw/cmsdist#9530

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DQM] py2/3 compatibility:drop use of future #46767

[DQM] py2/3 compatibility:drop use of future #46767

smuzaffar commented Nov 22, 2024

cmsbuild commented Nov 22, 2024 •

edited

Loading

cmsbuild commented Nov 22, 2024

cmsbuild commented Nov 22, 2024

smuzaffar commented Nov 25, 2024

cmsbuild commented Nov 25, 2024

antoniovagnerini commented Nov 25, 2024

antoniovagnerini commented Nov 25, 2024

smuzaffar commented Nov 25, 2024

antoniovagnerini commented Nov 25, 2024

antoniovagnerini commented Nov 25, 2024

cmsbuild commented Nov 25, 2024

antoniovagnerini commented Nov 25, 2024

cmsbuild commented Nov 25, 2024

mandrenguyen commented Nov 25, 2024

[DQM] py2/3 compatibility:drop use of __future__ #46767

[DQM] py2/3 compatibility:drop use of __future__ #46767

Conversation

smuzaffar commented Nov 22, 2024

cmsbuild commented Nov 22, 2024 • edited Loading

cmsbuild commented Nov 22, 2024

cmsbuild commented Nov 22, 2024

smuzaffar commented Nov 25, 2024

cmsbuild commented Nov 25, 2024

Unit Tests

Comparison Summary

antoniovagnerini commented Nov 25, 2024

antoniovagnerini commented Nov 25, 2024

smuzaffar commented Nov 25, 2024

antoniovagnerini commented Nov 25, 2024

antoniovagnerini commented Nov 25, 2024

cmsbuild commented Nov 25, 2024

Comparison Summary

antoniovagnerini commented Nov 25, 2024

cmsbuild commented Nov 25, 2024

mandrenguyen commented Nov 25, 2024

[DQM] py2/3 compatibility:drop use of future #46767

[DQM] py2/3 compatibility:drop use of future #46767

cmsbuild commented Nov 22, 2024 •

edited

Loading