Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RECONSTRUCTION] py2/3 compatibility:drop use of __future__ #46765

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

smuzaffar
Copy link
Contributor

see #46762

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • CommonTools/ParticleFlow (reconstruction)
  • EventFilter/CSCRawToDigi (reconstruction)
  • EventFilter/HcalRawToDigi (reconstruction)
  • EventFilter/SiStripRawToDigi (reconstruction)
  • JetMETCorrections/Modules (reconstruction)
  • MagneticField/Engine (reconstruction)
  • MagneticField/Interpolation (reconstruction)
  • PhysicsTools/IsolationAlgos (reconstruction)
  • PhysicsTools/SelectorUtils (reconstruction)
  • RecoBTag/CTagging (reconstruction)
  • RecoBTag/ONNXRuntime (reconstruction)
  • RecoBTag/PerformanceDB (reconstruction)
  • RecoEgamma/EgammaElectronProducers (reconstruction)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoLocalCalo/HcalRecAlgos (reconstruction)
  • RecoLocalTracker/SiStripClusterizer (reconstruction)
  • RecoMET/METFilters (reconstruction)
  • RecoParticleFlow/PFClusterProducer (reconstruction)
  • RecoTauTag/Configuration (reconstruction)
  • RecoTauTag/RecoTau (reconstruction)
  • RecoTracker/TkSeedGenerator (reconstruction)
  • TrackPropagation/RungeKutta (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @AnnikaStein, @GiacomoSguazzoni, @Martin-Grunewald, @Ming-Yan, @Prasant1993, @ReyerBand, @Sam-Harper, @Senphy, @VinInn, @VourMa, @a-kapoor, @abdoulline, @afiqaize, @ahinzmann, @alesaggio, @andrzejnovak, @apsallid, @argiro, @azotz, @barvic, @bsunanda, @castaned, @clelange, @dgulhan, @echabert, @felicepantaleo, @gbenelli, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jainshilpi, @jdamgov, @jdolen, @jlidrych, @lgray, @mariadalfonso, @mbluj, @missirol, @mmarionncern, @mmusich, @mtosi, @namapane, @nhanvtran, @ptcox, @ram1123, @rappoccio, @rchatter, @robervalwalsh, @rovere, @sameasy, @schoef, @seemasharmafnal, @sobhatta, @thomreis, @threus, @valsdav, @varuns23, @wang0jin, @yduhm, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 80KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-962679/43014/summary.html
COMMIT: e9abdc4
CMSSW: CMSSW_14_2_X_2024-11-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46765/43014/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 288 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3596288
  • DQMHistoTests: Total failures: 2419
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3593849
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 206 log files, 177 edm output root files, 47 DQM output files
  • TriggerResults: found differences in 1 / 45 workflows

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e6d3b54 into cms-sw:master Nov 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants