Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to AlpakaCore README #46711

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Minor updates to AlpakaCore README #46711

merged 1 commit into from
Nov 16, 2024

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Nov 15, 2024

PR description:

The use of return std::move(...) in the ESProducer examples caught my eye, as the use of std::move() there has usually resulted in "pessimizing move" warnings (can't remember if from compiler or from clang-tidy). None of the test code in HeterogeneousCore/AlpakaTest uses std::move() in conjunction with return, so I think it is good to remove it from the example.

This also fixes one link.

Resolves cms-sw/framework-team#1091

PR validation:

None

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46711/42669

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaCore (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9e1d/42889/summary.html
COMMIT: 125c892
CMSSW: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46711/42889/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@fwyzard
Copy link
Contributor

fwyzard commented Nov 15, 2024 via email

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f43acb8 into cms-sw:master Nov 16, 2024
11 checks passed
@makortel makortel deleted the patch-7 branch November 18, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small update to AlpakaCore README
4 participants