-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor updates to AlpakaCore README #46711
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46711/42669
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
+1
…On Fri, 15 Nov 2024, 23:22 cmsbuild, ***@***.***> wrote:
+1
*Size*: This PR adds an extra 24KB to repository
*Summary*:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f9e1d/42889/summary.html
*COMMIT*: 125c892
<125c892>
*CMSSW*: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12
*User test area*: For local testing, you can use /cvmfs/
cms-ci.cern.ch/week1/cms-sw/cmssw/46711/42889/install.sh to create a dev
area with all the needed externals and cmssw changes.
Comparison Summary
*Summary*:
- You potentially added 1 lines
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_2_X_2024-11-15-1100+1f9e1d/65676/validateJR/logRootQA-events.log>
to the logs
- Reco comparison results: 64 differences found in the comparisons
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_2_X_2024-11-15-1100+1f9e1d/65676/validateJR.html>
- DQMHistoTests: Total files compared: 46
- DQMHistoTests: Total histograms compared: 3343764
- DQMHistoTests: Total failures: 1249
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_2_X_2024-11-15-1100+1f9e1d/65676/validateJR.html>
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3342495
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
- Checked 202 log files, 172 edm output root files, 46 DQM output files
- TriggerResults
<https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_2_X_2024-11-15-1100+1f9e1d/65676/triggerResults>:
no differences found
—
Reply to this email directly, view it on GitHub
<#46711 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7BTIM3TFNYITJLYV7WCXL2AZX25AVCNFSM6AAAAABR3YXG3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGA2DAOBTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The use of
return std::move(...)
in the ESProducer examples caught my eye, as the use ofstd::move()
there has usually resulted in "pessimizing move" warnings (can't remember if from compiler or from clang-tidy). None of the test code inHeterogeneousCore/AlpakaTest
usesstd::move()
in conjunction withreturn
, so I think it is good to remove it from the example.This also fixes one link.
Resolves cms-sw/framework-team#1091
PR validation:
None