Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noisy_ElectronSeedProducer_Correction_V1 : plugins part #46710

Merged

Conversation

archiron
Copy link
Contributor

PR description:

Finish the transition from infinity() to max()
Description: Solves the problem reported here.
The printouts were triggered because a mixed usage of max() and infinity()

PR validation:

compilation is OK, basics tests (scram b runtests or local tests) are OK too.
runTheMatrix.py -l limited -i all --ibeos tests are fine
41 40 39 34 17 1 1 1 1 1 1 tests passed, 2 0 0 0 0 0 0 0 0 0 0 failed
the 2 errors are DAS error (see runall-report-step123-.log).
runall-report-step123-.logation is OK, basics tests (scram b runtests or local tests) are OK too.
runall-report-step123-.log

@beaudett

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @archiron for master.

It involves the following packages:

  • DataFormats/EgammaReco (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@Prasant1993, @Sam-Harper, @a-kapoor, @afiqaize, @jainshilpi, @lgray, @missirol, @mmusich, @rovere, @sameasy, @sobhatta, @varuns23 this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a7fa3/42886/summary.html
COMMIT: b523d12
CMSSW: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46710/42886/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Nov 15, 2024

type egamma, bug-fix

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3b1eb1f into cms-sw:master Nov 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants