-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noisy_ElectronSeedProducer_Correction_V1 : plugins part #46710
Noisy_ElectronSeedProducer_Correction_V1 : plugins part #46710
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46710/42668 |
A new Pull Request was created by @archiron for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
type egamma, bug-fix |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Finish the transition from infinity() to max()
Description: Solves the problem reported here.
The printouts were triggered because a mixed usage of max() and infinity()
PR validation:
compilation is OK, basics tests (scram b runtests or local tests) are OK too.
runTheMatrix.py -l limited -i all --ibeos tests are fine
41 40 39 34 17 1 1 1 1 1 1 tests passed, 2 0 0 0 0 0 0 0 0 0 0 failed
the 2 errors are DAS error (see runall-report-step123-.log).
runall-report-step123-.logation is OK, basics tests (scram b runtests or local tests) are OK too.
runall-report-step123-.log
@beaudett