Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mask production for empty seeding region #46709

Merged

Conversation

felicepantaleo
Copy link
Contributor

This PR fixes #46698 for wf with HFNose in the Geometry.

  • Moved mask update logic outside the conditional block that checks for seeding regions to ensure it is always executed, regardless of whether seeding regions are available.
  • The mask is updated correctly even when no tracksters are produced.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2024

cms-bot internal usage

@felicepantaleo
Copy link
Contributor Author

test parameters:

  • workflow_opts= -w upgrade
  • workflow = 32034.0

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

  • RecoHGCal/TICL (upgrade, reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@apsallid, @forthommel, @hatakeyamak, @lecriste, @missirol, @rovere, @sameasy, @sobhatta, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@felicepantaleo
Copy link
Contributor Author

@cmsbuild please test

@jfernan2
Copy link
Contributor

fixes #46698

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6371ae/42882/summary.html
COMMIT: 6c65e58
CMSSW: CMSSW_14_2_X_2024-11-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46709/42882/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
32034.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 1042 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3343764
  • DQMHistoTests: Total failures: 401
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3343343
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 205 log files, 176 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@Moanwar
Copy link
Contributor

Moanwar commented Nov 15, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d1bd212 into cms-sw:master Nov 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relval 32034.0 step 3: SIGSEGV in ticl::ClusterFilterByAlgoAndSizeAndLayerRange::filter
5 participants