-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix base_wf_number_2022
(should be base_wf
)
#46701
Conversation
type bug-fix |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46701/42650 |
A new Pull Request was created by @AdrianoDee for master. It involves the following packages:
@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
please test |
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test test-runTheMatrix-interactive had ERRORS Comparison SummarySummary:
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46701/42657 |
@cms-sw/upgrade-l2 sorry to bother, if you could have a look at this I would like to try to have this included before pre4 is closed ( if @cms-sw/orp-l2 agree ). |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
Thanks @Moanwar ! |
@AdrianoDee , for |
@smuzaffar in this specific case I didn't really wanted to test any wf but just check that the matrix tests were not failing anymore with
and they don't
I'll resend them with a dummy wf. |
test parameters:
|
please test |
-1 Failed Tests: RelVals RelValsValueError: Undefined workflows: 2024.101001 |
test parameters:
|
please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
+1 |
PR description:
Small fix prompted by #46610 (comment).