Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base_wf_number_2022 (should be base_wf) #46701

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

AdrianoDee
Copy link
Contributor

PR description:

Small fix prompted by #46610 (comment).

@AdrianoDee
Copy link
Contributor Author

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,Run4,data_highstats

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0be0a/42858/summary.html
COMMIT: 912937b
CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46701/42858/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-runTheMatrix-interactive had ERRORS

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

@AdrianoDee
Copy link
Contributor Author

@cms-sw/upgrade-l2 sorry to bother, if you could have a look at this I would like to try to have this included before pre4 is closed ( if @cms-sw/orp-l2 agree ).

@Moanwar
Copy link
Contributor

Moanwar commented Nov 15, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@AdrianoDee
Copy link
Contributor Author

Thanks @Moanwar !

@smuzaffar
Copy link
Contributor

@AdrianoDee , for relvals_opt (under test parameters ) one needs to provide the workflow/relval number too. I suggest to restart the tests by add relvals = <wf_num> in #46701 (comment)

@AdrianoDee
Copy link
Contributor Author

@smuzaffar in this specific case I didn't really wanted to test any wf but just check that the matrix tests were not failing anymore with

ignoring non-requested file relval_premix
ignoring non-requested file relval_nano
processing relval_data_highstats
ERROR importing file  relval_data_highstats name 'base_wf_number_2022' is not defined
ignoring non-requested file relval_standard

and they don't

ignoring non-requested file relval_premix
ignoring non-requested file relval_nano
processing relval_data_highstats
ignoring non-requested file relval_standard
ignoring non-requested file relval_highstats

I'll resend them with a dummy wf.

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • relvals = 2024.101001
  • relvals_opt = --what data_highstats

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0be0a/42883/summary.html
COMMIT: b4be55d
CMSSW: CMSSW_14_2_X_2024-11-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46701/42883/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 2024.101001

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • relvals = 2024.101005
  • relvals_opt = --what data_highstats

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0be0a/42888/summary.html
COMMIT: b4be55d
CMSSW: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46701/42888/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3343764
  • DQMHistoTests: Total failures: 465
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3343279
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b7ea111 into cms-sw:master Nov 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants