Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X] Update the egamma regression for 2023 UPC PbPb rereco and the corresponding GTs in autoCond #46685

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

stahlleiton
Copy link
Contributor

@stahlleiton stahlleiton commented Nov 13, 2024

PR description:

Backport of #46562

The data and HI MC Gts are updated in autoCond to take the new regressions into account:

@mandrenguyen

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2024

A new Pull Request was created by @stahlleiton for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • RecoEcal/EgammaClusterProducers (reconstruction)
  • RecoEgamma/EgammaElectronProducers (reconstruction)
  • RecoEgamma/EgammaTools (reconstruction)

@AdrianoDee, @Moanwar, @atpathak, @cmsbuild, @consuegs, @DickyChant, @jfernan2, @mandrenguyen, @miquork, @perrotta, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @Prasant1993, @ReyerBand, @Sam-Harper, @a-kapoor, @afiqaize, @argiro, @fabiocos, @jainshilpi, @lgray, @makortel, @missirol, @mmusich, @ram1123, @rchatter, @rovere, @rsreds, @sameasy, @slomeo, @sobhatta, @thomreis, @tocheng, @valsdav, @varuns23, @wang0jin, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2024

cms-bot internal usage

@mandrenguyen
Copy link
Contributor

backport of #46562

@mandrenguyen
Copy link
Contributor

please test workflows 180,180.1,181,181.1,141.901,141.902,142.0,142.901,142.902,142.903

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ac88e/42810/summary.html
COMMIT: fafe2a4
CMSSW: CMSSW_14_1_X_2024-11-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46685/42810/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test TestDQMOnlineClient-visualization_secondInstance had ERRORS
---> test TestDQMOnlineClient-visualization had ERRORS

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 2260 differences found in the comparisons
  • DQMHistoTests: Total files compared: 56
  • DQMHistoTests: Total histograms compared: 4331032
  • DQMHistoTests: Total failures: 6138
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 4324870
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.094 KiB( 55 files compared)
  • DQMHistoSizes: changed ( 141.901 ): -0.094 KiB JetMET/SUSYDQM
  • Checked 238 log files, 198 edm output root files, 56 DQM output files
  • TriggerResults: no differences found

@stahlleiton
Copy link
Contributor Author

Is the error in the tests related to this PR?

@cmsbuild
Copy link
Contributor

Pull request #46685 was updated. @AdrianoDee, @Moanwar, @atpathak, @cmsbuild, @consuegs, @DickyChant, @jfernan2, @mandrenguyen, @miquork, @perrotta, @srimanob, @subirsarkar can you please check and sign again.

@stahlleiton
Copy link
Contributor Author

@perrotta : Fixed the merge conflicts with the Alca PR that got recently merged.

@AdrianoDee
Copy link
Contributor

please test

@AdrianoDee
Copy link
Contributor

please abort

@AdrianoDee
Copy link
Contributor

please test workflows 180,180.1,181,181.1,141.901,141.902,142.0,142.901,142.902,142.903

@perrotta
Copy link
Contributor

@stahlleiton please take care of #46562 (comment) also in this backport

@stahlleiton stahlleiton changed the title [14_1_X] Update the egamma regression for 2023 UPC PbPb rereco [14_1_X] Update the egamma regression for 2023 UPC PbPb rereco and the corresponding GTs in autoCond Nov 16, 2024
@stahlleiton
Copy link
Contributor Author

@stahlleiton please take care of #46562 (comment) also in this backport

@perrotta : done, the PR title and description has been updated.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ac88e/42898/summary.html
COMMIT: 1846c33
CMSSW: CMSSW_14_1_X_2024-11-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46685/42898/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 2249 differences found in the comparisons
  • DQMHistoTests: Total files compared: 56
  • DQMHistoTests: Total histograms compared: 4331032
  • DQMHistoTests: Total failures: 6135
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 4324873
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.094 KiB( 55 files compared)
  • DQMHistoSizes: changed ( 141.901 ): -0.094 KiB JetMET/SUSYDQM
  • Checked 238 log files, 198 edm output root files, 56 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@Moanwar
Copy link
Contributor

Moanwar commented Nov 18, 2024

+Upgrade

@stahlleiton
Copy link
Contributor Author

@cms-sw/alca-l2 , @cms-sw/pdmv-l2 : please review/sign this PR , thanks

@AdrianoDee
Copy link
Contributor

+pdmv

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bc597e7 into cms-sw:CMSSW_14_1_X Nov 26, 2024
9 checks passed
@stahlleiton stahlleiton deleted the EGReg_UPC_14_1_X branch November 26, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants