Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.X] fix HLT online DQM client to cope with PbPb HLT strip collections #46667

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 12, 2024

backport of #46622

PR description:

Title says it all, aimed to fix the empty Strip collections at HLT seen in the early 2024 PbPb runs, e.g. 387886 (link to DQM)

PR validation:

See See #46622 (comment).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #46622 to the 2024 PbPb data-taking cycle.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 12, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • DQM/Integration (dqm)
  • DQMOffline/Trigger (dqm)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @rseidita can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @batinkov, @cericeci, @francescobrivio, @jhgoh, @missirol, @mtosi, @rociovilar, @silviodonato, @threus, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 12, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Nov 12, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-311a28/42750/summary.html
COMMIT: 2f7cf2c
CMSSW: CMSSW_14_1_X_2024-11-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46667/42750/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565669
  • DQMHistoTests: Total failures: 352
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565297
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@mmusich
Copy link
Contributor Author

mmusich commented Nov 12, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e601d0d into cms-sw:CMSSW_14_1_X Nov 13, 2024
9 checks passed
@mmusich mmusich deleted the mm_fix_hlt_client_HIon_14_1_X branch November 13, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants