refactor: disable DQM pb files production #46662

gabrielmscampos · 2024-11-11T15:36:29Z

Replace the current dqmSaver class with a stub class, thus disabling the pb production everywhere this EDAnalyzer is used.

PR description:

Since we are disabling the anelasticDQM process in the DQM online machines, we are going to start accumulating PB files there. The simplest solution to avoid accumulating files is to disable the PB file production in all clients, because:

They were created for the New DQMGUI, that is not deployed (which means we are wasting resources generating those files).
It is easier to replace only this file (if not used outside DQM) instead of disabling the PB production in each client.

PR validation:

Tested in DQM Playback environment, all plots behaving as expected and PB files are not created anymore.

The original dqmSaver (PB) EDAnalyzer is called from the DQM clients under DQM/Integration/python/clients (results found using grep -rn "dqmSaverPB" *, the BeamMonitor test and following files in EventFilter (results found using grep -rn "DQMFileSaverPB_cfi" *):

Nevertheless, the original EDAnalyzer seems to be ignored in HLTTrigger confdb, given the following:

HLTrigger/Configuration/python/Tools/confdb.py#L701

Any input on this is appreciated, since later on a flag with the same name seems to be written in the auto generated file:

HLTrigger/Configuration/python/Tools/confdb.py#L814

cmsbuild · 2024-11-11T15:36:55Z

cms-bot internal usage

cmsbuild · 2024-11-11T15:38:06Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46662/42585

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46662/42585/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46662/42585/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-11-11T15:42:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46662/42586

cmsbuild · 2024-11-11T15:43:10Z

A new Pull Request was created by @gabrielmscampos for master.

It involves the following packages:

DQMServices/FileIO (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

gabrielmscampos · 2024-11-11T15:43:16Z

FYI @mmusich

mmusich · 2024-11-11T15:45:54Z

@cms-sw/hlt-l2 @fwyzard FYI

mmusich · 2024-11-11T15:48:01Z

concerning:

Nevertheless, the original EDAnalyzer seems to be ignored in HLTTrigger confdb, given the following:
HLTrigger/Configuration/python/Tools/confdb.py#L701

it is ignored in the offline dumps of the HLT menu, but we definitely use it the online HLT menu and keep wanting to do so.

mmusich · 2024-11-11T15:49:38Z

It is easier to replace only this file (if not used outside DQM) instead of disabling the PB production in each client.

why?

Martin-Grunewald · 2024-11-11T15:52:53Z

Nevertheless, the original EDAnalyzer seems to be ignored in HLTTrigger confdb, given the following:

https://github.com/cms-sw/cmssw/blob/master/HLTrigger/Configuration/python/Tools/confdb.py#L701

Any input on this is appreciated, since later on a flag with the same name seems to be written in the auto generated file:

https://github.com/cms-sw/cmssw/blob/master/HLTrigger/Configuration/python/Tools/confdb.py#L814

Line 814 simple removes the module instance from the dump for offline!

gabrielmscampos · 2024-11-11T16:00:20Z

It is easier to replace only this file (if not used outside DQM) instead of disabling the PB production in each client.

why?

We are modifying a single line in the DQMFileSaverPB_cfi instead of 46 files in DQM/Integration/python/clients/ + DQM/BeamMonitor/test/Online_BeamMonitor_file.py.
It will be easier to revert when the PB files are actually needed in the future.

However, since the online HLT menu is using it. I guess the only solution is modifying all the files.

mmusich · 2024-11-11T16:01:41Z

DQMServices/FileIO/python/DQMFileSaverPB_cfi.py

+# by replacing the dqmSaver with a stub dqmSaver.
+# dqmSaver = cms.EDAnalyzer("DQMFileSaverPB",
+
+dqmSaver = cms.EDAnalyzer("DQMFileSaverPBStub",


@Martin-Grunewald is this going to mess up with the parsing of the confDB GUI?

shall we make this

cmssw/DQMServices/FileIO/plugins/DQMFileSaverPB.cc

Line 228 in cea2496

descriptions.addDefault(desc);

actually write out a cfi with addWithDefaultLabel?

It would need a proper fillDescriptions method with all the parameters.

In the end these are two different plugins and thus need two separate cfi files (as each cfi file contains the class name).

Martin-Grunewald · 2024-11-11T16:02:30Z

DQMServices/FileIO/python/DQMFileSaverPB_cfi.py

+# by replacing the dqmSaver with a stub dqmSaver.
+# dqmSaver = cms.EDAnalyzer("DQMFileSaverPB",
+
+dqmSaver = cms.EDAnalyzer("DQMFileSaverPBStub",


This would remove the original DQMFileSaverPB from being seen by ConfDB parsing (no cfi file with it!) and thus no longer available for HLT menus online or offline. As Marco mentioned we want to use the plugin for online, so we'd need another solution here, for example, a new separate cfi file DQMFileSaverPBStub_cfi.py, and not removing the old one.

mmusich · 2024-11-11T16:06:40Z

However, since the online HLT menu is using it. I guess the only solution is modifying all the files.

I don't think this PR per se is going to be harmful to the HLT online, provided you address #46662 (comment)..

gabrielmscampos · 2024-11-11T16:19:05Z

However, since the online HLT menu is using it. I guess the only solution is modifying all the files.

I don't think this PR per se is going to be harmful to the HLT online, provided you address #46662 (comment)..

Got it, I can create a new EDAnalyzer for the DQM clients in order to preserve the current one for HLT.

Thanks!

mmusich · 2024-11-11T16:27:05Z

We are modifying a single line in the DQMFileSaverPB_cfi instead of 46 files in DQM/Integration/python/clients/ + DQM/BeamMonitor/test/Online_BeamMonitor_file.py.

maybe I am missing something trivial, but where is it referenced in all of these files?
It looks to me that all the inheritance comes from things like

cmssw/DQM/BeamMonitor/test/Online_BeamMonitor_file.py

Line 75 in cea2496

process.load("DQM.Integration.config.environment_cfi")

via

cmssw/DQM/Integration/python/config/environment_cfi.py

Line 83 in cea2496

from DQMServices.FileIO.DQMFileSaverPB_cfi import dqmSaver as dqmSaverPB

If you want to just change the behavior in the online clients can't you create a new cfi file for DQMFileSaverPBStub and replace it in the environment configuration fragment?

something like:

 from DQMServices.FileIO.DQMFileSaverPBStub_cfi import dqmSaver as dqmSaverPB

gabrielmscampos · 2024-11-11T16:37:02Z

We are modifying a single line in the DQMFileSaverPB_cfi instead of 46 files in DQM/Integration/python/clients/ + DQM/BeamMonitor/test/Online_BeamMonitor_file.py.

maybe I am missing something trivial, but where is it referenced in all of these files? It looks to me that all the inheritance comes from things like

cmssw/DQM/BeamMonitor/test/Online_BeamMonitor_file.py

Line 75 in cea2496

process.load("DQM.Integration.config.environment_cfi")

via

cmssw/DQM/Integration/python/config/environment_cfi.py

Line 83 in cea2496

from DQMServices.FileIO.DQMFileSaverPB_cfi import dqmSaver as dqmSaverPB

If you want to just change the behavior in the online clients can't you create a new cfi file for DQMFileSaverPBStub and replace it in the environment configuration fragment?

something like:
 from DQMServices.FileIO.DQMFileSaverPBStub_cfi import dqmSaver as dqmSaverPB 

Yes, that is what I'm going to do. Initially I thought in removing the references to dqmSaverPB in all clients, that is why I mentioned all the files. However, I'll update only the environment_cfi and cross-check this is not used elsewhere.

fwyzard · 2024-11-12T06:00:19Z

hold

cmsbuild · 2024-11-12T06:00:40Z

Pull request has been put on hold by @fwyzard
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild · 2024-11-14T12:30:46Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cf9c0/42835/summary.html
COMMIT: a32c7d3
CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46662/42835/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS
---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3343764
DQMHistoTests: Total failures: 397
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343347
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

nothingface0 · 2024-11-14T12:42:10Z

@smuzaffar The TestDQMServicesDemo seems to fail due to a missing (automatically generated?) cfi file:

----- Begin Fatal Exception 14-Nov-2024 10:49:09 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_2_X_2024-11-13-2300/src/DQMServices/Demo/test/run_analyzers_cfg.py
Exception Message:
 unknown python problem occurred.
ModuleNotFoundError: No module named 'DQMServices.Demo.test_cfi'

At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02863/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-11-13-2300/src/FWCore/ParameterSet/python/Config.py(762): load
  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_2_X_2024-11-13-2300/src/DQMServices/Demo/test/run_analyzers_cfg.py(7): <module>

----- End Fatal Exception -------------------------------------------------

Are we missing something?

smuzaffar · 2024-11-14T12:55:16Z

please test

looks like latest bot change cms-sw/cms-bot#2361 broke the PR testing

cmsbuild · 2024-11-14T16:08:43Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cf9c0/42846/summary.html
COMMIT: a32c7d3
CMSSW: CMSSW_14_2_X_2024-11-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46662/42846/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3343764
DQMHistoTests: Total failures: 424
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343320
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

antoniovagnerini · 2024-11-18T09:22:05Z

please test

cmsbuild · 2024-11-18T11:59:57Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cf9c0/42921/summary.html
COMMIT: a32c7d3
CMSSW: CMSSW_14_2_X_2024-11-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46662/42921/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3344340
DQMHistoTests: Total failures: 447
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343873
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

antoniovagnerini · 2024-11-18T15:26:28Z

Spurious errors in DQM bin-by-bin comparison in Tracker Phase 2 WS seem to have been introduced by #46717, which was merged 5 h ago , see https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_2_X_2024-11-17-0000+6d35e2/65692/29634.0_TTbar_14TeV+Run4D110/

antoniovagnerini · 2024-11-18T15:28:33Z

+1

spurious differences from HGCal DQM test (open issue Non reproducibility in HGCal DQM #46416)
spurious differences in TrackerPhase2OTL1Track test, most likely introduced from Phase2-hgx360T Making ready for updating Phase2 geometry #46717

cmsbuild · 2024-11-18T15:28:57Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-11-18T21:30:59Z

+1

cmsbuild added this to the CMSSW_14_2_X milestone Nov 11, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Nov 11, 2024

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Nov 11, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 11, 2024

mmusich reviewed Nov 11, 2024

View reviewed changes

Martin-Grunewald reviewed Nov 11, 2024

View reviewed changes

cmsbuild added tests-rejected and removed tests-started labels Nov 14, 2024

cmsbuild added tests-started and removed tests-rejected labels Nov 14, 2024

cmsbuild added tests-rejected and removed tests-started labels Nov 14, 2024

cmsbuild mentioned this pull request Nov 16, 2024

Remove legacy L1T digis dependencies in Online DQM #46716

Merged

cmsbuild added tests-started and removed tests-rejected labels Nov 18, 2024

cmsbuild added tests-approved and removed tests-started labels Nov 18, 2024

gabrielmscampos mentioned this pull request Nov 18, 2024

[14_1_X] refactor: disable DQM pb files production #46724

Merged

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Nov 18, 2024

cmsbuild added orp-approved and removed orp-pending labels Nov 18, 2024

cmsbuild merged commit 8fa55df into cms-sw:master Nov 18, 2024
11 checks passed

nothingface0 mentioned this pull request Nov 29, 2024

Added cherry-pick functionality to cmssw_deploy cms-DQM/fff_dqmtools#21

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: disable DQM pb files production #46662

refactor: disable DQM pb files production #46662

gabrielmscampos commented Nov 11, 2024

cmsbuild commented Nov 11, 2024 •

edited

Loading

cmsbuild commented Nov 11, 2024

cmsbuild commented Nov 11, 2024

cmsbuild commented Nov 11, 2024

gabrielmscampos commented Nov 11, 2024

mmusich commented Nov 11, 2024 •

edited

Loading

mmusich commented Nov 11, 2024 •

edited

Loading

mmusich commented Nov 11, 2024

Martin-Grunewald commented Nov 11, 2024 •

edited

Loading

gabrielmscampos commented Nov 11, 2024

mmusich Nov 11, 2024 •

edited

Loading

mmusich Nov 11, 2024 •

edited

Loading

Martin-Grunewald Nov 11, 2024

Martin-Grunewald Nov 11, 2024

Martin-Grunewald Nov 11, 2024 •

edited

Loading

mmusich commented Nov 11, 2024 •

edited

Loading

gabrielmscampos commented Nov 11, 2024

mmusich commented Nov 11, 2024 •

edited

Loading

gabrielmscampos commented Nov 11, 2024

fwyzard commented Nov 12, 2024

cmsbuild commented Nov 12, 2024

cmsbuild commented Nov 14, 2024

nothingface0 commented Nov 14, 2024

smuzaffar commented Nov 14, 2024

cmsbuild commented Nov 14, 2024

antoniovagnerini commented Nov 18, 2024

cmsbuild commented Nov 18, 2024

antoniovagnerini commented Nov 18, 2024

antoniovagnerini commented Nov 18, 2024

cmsbuild commented Nov 18, 2024

mandrenguyen commented Nov 18, 2024

refactor: disable DQM pb files production #46662

refactor: disable DQM pb files production #46662

Conversation

gabrielmscampos commented Nov 11, 2024

PR description:

PR validation:

cmsbuild commented Nov 11, 2024 • edited Loading

cmsbuild commented Nov 11, 2024

cmsbuild commented Nov 11, 2024

cmsbuild commented Nov 11, 2024

gabrielmscampos commented Nov 11, 2024

mmusich commented Nov 11, 2024 • edited Loading

mmusich commented Nov 11, 2024 • edited Loading

mmusich commented Nov 11, 2024

Martin-Grunewald commented Nov 11, 2024 • edited Loading

gabrielmscampos commented Nov 11, 2024

mmusich Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

mmusich Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

Martin-Grunewald Nov 11, 2024

Choose a reason for hiding this comment

Martin-Grunewald Nov 11, 2024

Choose a reason for hiding this comment

Martin-Grunewald Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

mmusich commented Nov 11, 2024 • edited Loading

gabrielmscampos commented Nov 11, 2024

mmusich commented Nov 11, 2024 • edited Loading

gabrielmscampos commented Nov 11, 2024

fwyzard commented Nov 12, 2024

cmsbuild commented Nov 12, 2024

cmsbuild commented Nov 14, 2024

Unit Tests

Comparison Summary

nothingface0 commented Nov 14, 2024

smuzaffar commented Nov 14, 2024

cmsbuild commented Nov 14, 2024

Unit Tests

Comparison Summary

antoniovagnerini commented Nov 18, 2024

cmsbuild commented Nov 18, 2024

Comparison Summary

antoniovagnerini commented Nov 18, 2024

antoniovagnerini commented Nov 18, 2024

cmsbuild commented Nov 18, 2024

mandrenguyen commented Nov 18, 2024

cmsbuild commented Nov 11, 2024 •

edited

Loading

mmusich commented Nov 11, 2024 •

edited

Loading

mmusich commented Nov 11, 2024 •

edited

Loading

Martin-Grunewald commented Nov 11, 2024 •

edited

Loading

mmusich Nov 11, 2024 •

edited

Loading

mmusich Nov 11, 2024 •

edited

Loading

Martin-Grunewald Nov 11, 2024 •

edited

Loading

mmusich commented Nov 11, 2024 •

edited

Loading

mmusich commented Nov 11, 2024 •

edited

Loading