Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Phase2TrackerMonitorDigi #46575

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Improve Phase2TrackerMonitorDigi #46575

merged 1 commit into from
Nov 5, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 31, 2024 •
edited
Loading

PR description:

PR in response to #46510

Improve Phase2TrackerMonitorDigi

  • merge header file in the plugin implementation
  • const correctness of input parameter
  • LogInfo -> LogDebug (to avoid large amount of allocations)

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Oct 31, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2024 •
edited
Loading

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Oct 31, 2024

type performance-improvements

@mmusich mmusich mentioned this pull request Oct 31, 2024
Closed
@mmusich
Copy link
Contributor Author

mmusich commented Oct 31, 2024

@emiglior @suchandradutta @henriettepetersen FYI

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46575/42464

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@mmusich
Improve phase2TrackerMonitorDigi:
76205cb 
- merge header file in the plugin implementation
- const correctness of input parameter
- LogInfo -> LogDebug (to avoid large amount of allocations)
@mmusich mmusich force-pushed the mm_dev_improvePhase2TrackerMonitorDigi branch from 3f77988 to 76205cb Compare October 31, 2024 21:38
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46575/42465

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/SiTrackerPhase2 (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@arossi83, @sroychow this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 31, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25bb99/42525/summary.html
COMMIT: 76205cb
CMSSW: CMSSW_14_2_X_2024-10-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46575/42525/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
  • 2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
  • 2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log
Expand to see more relval errors ...
  • 2024.101001
  • 2024.000001
  • 2024.001001
  • 2024.100001
  • 2024.101001

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3569567
  • DQMHistoTests: Total failures: 485
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3569062
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Nov 1, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25bb99/42531/summary.html
COMMIT: 76205cb
CMSSW: CMSSW_14_2_X_2024-10-31-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46575/42531/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9776ebc into cms-sw:master Nov 5, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_improvePhase2TrackerMonitorDigi branch November 5, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved dqm-approved fully-signed orp-approved performance-improvements tests-approved trk
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
4 participants
@mmusich @cmsbuild @antoniovagnerini @mandrenguyen