Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DQM Certification JSON Parsing From Web in das-up-to-nevents.py #46559

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

AdrianoDee
Copy link
Contributor

PR description:

Apparenlty the names of the certification jsons have changed in https://cms-service-dqmdc.web.cern.ch/CAF/certification/Collisions24/ and this is causing das-up-to-nevents.py to fail.

PR validation:

das-up-to-nevents.py -d /JetMET0/Run2024D-v1/RAW -e 10000 runs with web fallback.

@AdrianoDee
Copy link
Contributor Author

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2024

cms-bot internal usage

@AdrianoDee AdrianoDee changed the title Fix DQM json parsing from web Fix DQM Certification JSON Parsing From Web Oct 30, 2024
@AdrianoDee
Copy link
Contributor Author

please test

@AdrianoDee AdrianoDee changed the title Fix DQM Certification JSON Parsing From Web Fix DQM Certification JSON Parsing From Web in das-up-to-nevents.py Oct 30, 2024
@AdrianoDee
Copy link
Contributor Author

urgent

To fix PR tests

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @Moanwar, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

@AdrianoDee , this can happen in future again ... right? How we can avoid this ?

@AdrianoDee
Copy link
Contributor Author

@AdrianoDee , this can happen in future again ... right? How we can avoid this ?

In principle it should be safe now. What changed was not really the name of the json the wfs target (that is still Cert_{Collisions|Cosmics}YEAR_Run1_RunN_{Golden|Muon}.json). It was the naming of those to be discarded from the list. As is they will be discarded earlier in the chain. I don't expect the standard json to change name without being properly announced.

On a side note, I don't understand why the bot tests do not see /eos/user/c/cmsdqm/www/CAF/certification/ (that would avoid to use the website fallback).

@smuzaffar
Copy link
Contributor

@AdrianoDee , eos is not mounted on build nodes that is why /eos/user/c/cmsdqm/www/CAF/certification/ is not accessible

@AdrianoDee
Copy link
Contributor Author

@AdrianoDee , eos is not mounted on build nodes that is why /eos/user/c/cmsdqm/www/CAF/certification/ is not accessible

Understood, thanks. Didn't know it

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-109497/42486/summary.html
COMMIT: 3478e78
CMSSW: CMSSW_14_2_X_2024-10-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46559/42486/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor Author

+pdmv

@AdrianoDee
Copy link
Contributor Author

@cms-sw/upgrade-l2 let me know if this is fine for you: it would fix all the PR failures.

@Moanwar
Copy link
Contributor

Moanwar commented Oct 31, 2024

+Upgrade
Thanks! @AdrianoDee

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants