-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DQM Certification JSON Parsing From Web in das-up-to-nevents.py
#46559
Conversation
type bug-fix |
cms-bot internal usage |
please test |
das-up-to-nevents.py
urgent To fix PR tests |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46559/42440 |
A new Pull Request was created by @AdrianoDee for master. It involves the following packages:
@AdrianoDee, @Moanwar, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@AdrianoDee , this can happen in future again ... right? How we can avoid this ? |
In principle it should be safe now. What changed was not really the name of the json the wfs target (that is still On a side note, I don't understand why the bot tests do not see |
@AdrianoDee , |
Understood, thanks. Didn't know it |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
+pdmv |
@cms-sw/upgrade-l2 let me know if this is fine for you: it would fix all the PR failures. |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Apparenlty the names of the certification jsons have changed in https://cms-service-dqmdc.web.cern.ch/CAF/certification/Collisions24/ and this is causing
das-up-to-nevents.py
to fail.PR validation:
das-up-to-nevents.py -d /JetMET0/Run2024D-v1/RAW -e 10000
runs with web fallback.