Fix to L1 ZDC Emulation to fix Et Sum truncation.

[hjbossi]

PR description:

This PR is a fix for the ZDC L1 emulation. Previously, the Et Sums were "compressed" to a value of 0 to 255, which is typical for the HCAL setup. However for the ZDC Et Sums, we would like the Et sums to go from 0 to 1023 in order to be consistent with what is included in the firmware. As the ZDC 1n OR trigger threshold is 16, this compression is not noticeable in the ZDC trigger rates, or emulated sums when focusing on lower values. However, when considering higher values this issue becomes clear.

PR validation:

This was tested using 10,000 events, using a replay of 2023 data using 14_1_X see slides.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR will need to be backported to 14_1_X as it is intended for HI and pp ref data-taking.

Tagging @icali @mandrenguyen @Michael-Krohn @JHiltbrand

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46500/42351

[cmsbuild]

A new Pull Request was created by @hjbossi for master.

It involves the following packages:

• L1Trigger/L1TZDC (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

urgent

[mandrenguyen]

please test workflow 142
Not sure that actually tests the functionality, but it looks the most promising

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0294f1/42364/summary.html
COMMIT: 4b82a2b
CMSSW: CMSSW_14_2_X_2024-10-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46500/42364/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @fabiocos MTD validation: update vertex density plots #46476
• @langufo Introduce support for cluster splitting and JetCore iteration in Phase-2 track reconstruction #46001
• @wddgit Fix unlabeled case in mayConsumes EventSetup #46484
• @hqucms Fix memory leak in GenParticles2HepMCConverter #46203
• @bsunanda Run2-hcx377 Put all 2015 scenarios using the same hcalRecNumbering.xml file #46430

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0294f1/42364/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0294f1/42364/git-merge-result

Comparison Summary

Summary:

• You potentially added 69 lines to the logs
• Reco comparison results: 2062 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3626213
• DQMHistoTests: Total failures: 5321
• DQMHistoTests: Total nulls: 13
• DQMHistoTests: Total successes: 3620859
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -21.466 KiB( 46 files compared)
• DQMHistoSizes: changed ( 141.044 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 24834.911,... ): -3.577 KiB MTD/Vertices
• Checked 205 log files, 174 edm output root files, 47 DQM output files
• TriggerResults: found differences in 1 / 45 workflows

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1