[14_1_X] Update the PbPb skims for 2024 data taking

[flodamas]

PR description:

Backport of #46447

[cmsbuild]

A new Pull Request was created by @flodamas for CMSSW_14_1_X.

It involves the following packages:

• Configuration/Skimming (pdmv)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Update the PbPb skims for 2024 data taking #46447

[cmsbuild]

cms-bot internal usage

[mandrenguyen]

backport of #46447

[youyingli]

@cms-sw/pdmv-l2, could you please test it?

[mandrenguyen]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc5dc7/42381/summary.html
COMMIT: 041c459
CMSSW: CMSSW_14_1_X_2024-10-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46458/42381/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3562835
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3562803
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.02 KiB( 45 files compared)
• DQMHistoSizes: changed ( 140.56 ): -0.012 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 140.56 ): -0.008 KiB MessageLogger/Warnings
• Checked 199 log files, 169 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #46458 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.

[cmsbuild]

Pull request #46458 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.

[mandrenguyen]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc5dc7/42401/summary.html
COMMIT: da5d10d
CMSSW: CMSSW_14_1_X_2024-10-27-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46458/42401/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3562835
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3562809
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.02 KiB( 45 files compared)
• DQMHistoSizes: changed ( 140.56 ): -0.012 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 140.56 ): -0.008 KiB MessageLogger/Warnings
• Checked 199 log files, 169 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

urgent

[cmsbuild]

Pull request #46458 was updated. @AdrianoDee, @cmsbuild, @DickyChant, @miquork can you please check and sign again.

[mandrenguyen]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc5dc7/42521/summary.html
COMMIT: 20891cb
CMSSW: CMSSW_14_1_X_2024-10-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46458/42521/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cfmcginn [14_1_X] Add PbPbHighPtJets skim for 2024 PbPb backport #46514

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc5dc7/42521/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc5dc7/42521/git-merge-result

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3565669
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3565643
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.02 KiB( 45 files compared)
• DQMHistoSizes: changed ( 140.56 ): -0.012 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 140.56 ): -0.008 KiB MessageLogger/Warnings
• Checked 199 log files, 169 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[AdrianoDee]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[mmusich]

@flodamas it appears that this change made the Tier0 replay with CMSSW_14_1_4_patch4 fail with the following error:

2024-11-01 22:25:10,703:CRITICAL:CMSSW:Error message: An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 374951 lumi: 31 event: 43921116 stream: 2
   [1] Running path 'ZMuSkimPathPbPb'
   [2] Calling method for module CandViewShallowCloneCombiner/'dimuonsForPbPbZMuSkim'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Candidate
Looking for module label: looseMuonsForPbPbZMuSkim
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

looseMuonsForPbPbZMuSkim produces a skimmed reco::TrackCollection while CandViewShallowCloneCombiner necessitates of a collection of reco::Candidate-s in input.
Shouldn't this be ConcretelooseMuonsForPbPbZMuSkim instead?

[flodamas]

Hi, indeed it should be and I have already made a PR #46584 (and #46585 for backport) to fix it.

Sorry for not having caught it before!