Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Update test_MC_*_setup unit tests #46440

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 18, 2024

backport of #46438
backport of #45614

PR description:

As discussed in #45888 (comment) these unit tests failed to catch an issue when running the reconstruction of data coming out the HLT produced in an earlier release.
I am updating the tests to use the latest and greatest ingredients as of Oct 18, 2024 (both in terms of releases and GlobalTags) as well as activating catching failures in the HLT step when it's failing in the target release.
Additionally for the RECO step for the 2022 use the customization function fixReading_12_4_X_Files as suggested at #45888 (comment).
This PR backports also #45614 that was never ported back to this cycle.

PR validation:

scram b runtests runs fine in this package

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #46438 and #45614 to 14.0.X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Oct 18, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-996f48/42294/summary.html
COMMIT: a5d4175
CMSSW: CMSSW_14_0_X_2024-10-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46440/42294/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor

+pdmv
I see all the test succeeding

@cmsbuild
Copy link
Contributor

Pull request #46440 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 18, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-996f48/42302/summary.html
COMMIT: 042134f
CMSSW: CMSSW_14_0_X_2024-10-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46440/42302/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor

+pdmv

@Moanwar
Copy link
Contributor

Moanwar commented Oct 21, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Oct 23, 2024

@cms-sw/orp-l2 is there anything outstanding with this backport, given the PR in cycles downstream have been validated in IBs?
Given that the 2022/2023 MC production will actually happen in this cycle, having a functional test here is arguably the most important.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 25, 2024

ping @cms-sw/orp-l2

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3b12432 into cms-sw:CMSSW_14_0_X Oct 25, 2024
9 checks passed
@mmusich mmusich deleted the update_test_mc_run_setup_14_0_X branch October 25, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants