-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] Update test_MC_*_setup
unit tests
#46440
[14.0.X] Update test_MC_*_setup
unit tests
#46440
Conversation
A new Pull Request was created by @mmusich for CMSSW_14_0_X. It involves the following packages:
@AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
@cmsbuild, please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
+pdmv |
…atest and greatest release and GTs
a5d4175
to
042134f
Compare
Pull request #46440 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again. |
@cmsbuild, please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
+pdmv |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 is there anything outstanding with this backport, given the PR in cycles downstream have been validated in IBs? |
ping @cms-sw/orp-l2 |
+1 |
backport of #46438
backport of #45614
PR description:
As discussed in #45888 (comment) these unit tests failed to catch an issue when running the reconstruction of data coming out the HLT produced in an earlier release.
I am updating the tests to use the latest and greatest ingredients as of Oct 18, 2024 (both in terms of releases and GlobalTags) as well as activating catching failures in the HLT step when it's failing in the target release.
Additionally for the RECO step for the 2022 use the customization function
fixReading_12_4_X_Files
as suggested at #45888 (comment).This PR backports also #45614 that was never ported back to this cycle.
PR validation:
scram b runtests
runs fine in this packageIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
backport of #46438 and #45614 to 14.0.X