Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue message if DB IOV updated during job [14_1] #46395

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

This adds a LogSystem output each time the CondDBESSource updates an IOV during the job. The output is avoided the first IOV check as the number of lines added to the log file is quite large.

This is meant to help diagnose a problem being seen in the HLT.

PR validation:

Code compiles.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #46393

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2024

A new Pull Request was created by @Dr15Jones for CMSSW_14_1_X.

It involves the following packages:

  • CondCore/CondDB (db)

@atpathak, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #46395 was updated. @atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-991fd2/42221/summary.html
COMMIT: 04eb37d
CMSSW: CMSSW_14_1_X_2024-10-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46395/42221/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

@perrotta perhaps you could sign this one as the master version is already signed.

@perrotta
Copy link
Contributor

+db

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #46393

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1552de9 into cms-sw:CMSSW_14_1_X Oct 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants