Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ByLS DQM plots for ES [14_1_X] #46378

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

kyungminparkdrums
Copy link

PR description:

This PR adds plots in EcalPreshower (ES) DQM : lumi-section (LS) based DQM plots in the new category of "ByLumiSection" ES DQM.

Full list of ES DQM plots added in the new ByLS plots is as follows:

EcalPreshower>ESIntegrityTask:
- Fiber error code
- Fiber off
- Integrity error
- ES OptoRX BC mismatch
- ES Slink CRC errors

EcalPreshower>ESOccupancyTask:
- ES occupancy with selected hits

EcalPreshower>ESRawDataTask:
- ES Orbit number DCC errors
- ES BX DCC errors
- ES L1A DCC errors 

PR validation:

PR is validated by running the ES online DQM configuration and verifying the plots on a test DQM GUI.

ES_ByLS_DQM

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the backport to 14_1_X. Master PR is #46348 and backports to 14_0_X is made in #46349

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2024

A new Pull Request was created by @kyungminparkdrums for CMSSW_14_1_X.

It involves the following packages:

  • DQM/EcalPreshowerMonitorModule (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @rchatter, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2024

cms-bot internal usage

@antoniovagnerini
Copy link

please test

@antoniovagnerini
Copy link

backport of #46348

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90ce57/42168/summary.html
COMMIT: 1242a50
CMSSW: CMSSW_14_1_X_2024-10-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46378/42168/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331166
  • DQMHistoTests: Total failures: 3442
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3327704
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1967.3200000000006 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 67.823 KiB EcalPreshower/ByLumiSection
  • DQMHistoSizes: changed ( 4.22,... ): 0.150 KiB EcalPreshower/ESIntegrityTask
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5d7641b into cms-sw:CMSSW_14_1_X Oct 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants