Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-hcx368X Complete the backport of #46115 where one added file was missed out #46352

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Oct 11, 2024

PR description:

Complete the backport of #46115 where one added file was missed out

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Origibal PR #46115

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_14_1_X.

It involves the following packages:

  • Geometry/ForwardCommonData (geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 11, 2024

cms-bot internal usage

@bsunanda
Copy link
Contributor Author

@antoniovilela, @mandrenguyen Could you please make this as Urgent.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@bsunanda
Copy link
Contributor Author

+geometry

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

test parameters:

  • addpkg = DQM/TrackingMonitorSource

@smuzaffar
Copy link
Contributor

please test

lets run the tests and checkout DQM/TrackingMonitorSource to make sure the failing unit test run during PR tests

@bsunanda
Copy link
Contributor Author

@smuzaffar this pr is good irrespective of testing with DQM

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f63698/42127/summary.html
COMMIT: 8b7c13e
CMSSW: CMSSW_14_1_X_2024-10-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46352/42127/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@bsunanda
Copy link
Contributor Author

urgent

@smuzaffar
Copy link
Contributor

@cms-sw/orp-l2 , this is needed for 14.1.X. This adds the missing Geometry/ForwardCommonData/data/rpd/2021/v2/rpd.xml needed by #46263 (which is already merged in 14.1.X)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cf00bee into cms-sw:CMSSW_14_1_X Oct 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants