[Backport to 14_1_X (#46345)]: Two Small Changes Related to ZDC LUTs

[JHiltbrand]

PR description:

In consultation with ZDC software expert @hjbossi and fellow HCAL trigger expert @Michael-Krohn.

First change in HcaluLUTTPGCoder

• When determining zeroing for the ZDC LUT, 1 pedestal width shall be used in the calculation on L655, rather than 5 pedestal widths.

Second change in HcalLutManager

• When generating the ZDC LUT XML, an additional else if case is added for topbottom FPGA label corresponding to u.

PR validation:

Only the first change to the HcaluLUTTPGCoder will result in some small changes to emulated ZDC trigger primitives. The second change to HcalLutManager only affects the generation of ZDC LUT XML files.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #46345 from 14_2_X.

[cmsbuild]

A new Pull Request was created by @JHiltbrand for CMSSW_14_1_X.

It involves the following packages:

• CalibCalorimetry/HcalTPGAlgos (l1, alca)
• CaloOnlineTools/HcalOnlineDb (db)

@aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @abdoulline, @bsunanda, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Two Small Changes Related to ZDC LUTs #46345

[cmsbuild]

cms-bot internal usage

[hjbossi]

Liking the original PR here explicitly to link the two! #46345

[perrotta]

backport of #46345

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02d76e/42119/summary.html
COMMIT: e993d6c
CMSSW: CMSSW_14_1_X_2024-10-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46346/42119/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

The relvals timed out after 4 hours.

[hjbossi]

Seems like this is a network error (not related to this PR) - would it be possible to re-launch the tests?

[perrotta]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02d76e/42145/summary.html
COMMIT: e993d6c
CMSSW: CMSSW_14_1_X_2024-10-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46346/42145/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 175 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331166
• DQMHistoTests: Total failures: 2002
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3329144
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

[hjbossi]

@aloeliger do you mind taking a look and signing? it is a backport of #46345

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1