Improved scripts used to write 2024 Geom DB payloads

[Dr15Jones]

PR description:

Removed use of sed and instead pass as command line arguments.

PR validation:

Tried to run steps outlined in #46290 but still failing because of a ZdcTopology being missing from the geometry description being used.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46306/42125

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• CondTools/Geometry (db)

@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @bsunanda, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

The most recent change avoids the exception from ZdcTopology.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46306/42126

[cmsbuild]

Pull request #46306 was updated. @atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please check and sign again.

[Dr15Jones]

assign geometry

[cmsbuild]

New categories assigned: geometry

@bsunanda,@civanch,@Dr15Jones,@kpedro88,@makortel,@mdhildreth you have been requested to review this Pull request/Issue and eventually sign? Thanks

[Dr15Jones]

With the Zdc change, I do see the following error

[2024-10-08 10:35:30,697] ERROR: There is no tag, global tag or (unique) payload named XMLFILE_Geometry_142DD4hepV1_Extended2024ZeroMaterial_mc in the database.

which I do not know if that is a real error or an expected message.

[Dr15Jones]

With the last change, I found the bug causing the ERROR and now everything appears to run without a problem.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46306/42134

[cmsbuild]

Pull request #46306 was updated. @Dr15Jones, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @perrotta can you please check and sign again.

[perrotta]

+db

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b53b62/42061/summary.html
COMMIT: fa5f126
CMSSW: CMSSW_14_2_X_2024-10-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46306/42061/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 111 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331066
• DQMHistoTests: Total failures: 2918
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328128
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[bsunanda]

+geometry

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1