Fix uninitialized values in HcalTopology

[Dr15Jones]

PR description:

This problem was seen in attempts to create the new DB entries.

PR validation:

Code compiles. Running the job seems to produce reasonable values for HBSize_, etc.

[Dr15Jones]

Please test

[cmsbuild]

cms-bot internal usage

[Dr15Jones]

NOTE: the logic in the two different constructors should be unified such that there is only one method doing the work.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46305/42124

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• Geometry/CaloTopology (geometry)

@Dr15Jones, @bsunanda, @civanch, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @bsunanda, @fabiocos, @martinamalberti, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-905145/42050/summary.html
COMMIT: 7d67e27
CMSSW: CMSSW_14_2_X_2024-10-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46305/42050/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 50 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331066
• DQMHistoTests: Total failures: 3851
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327195
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

hold

The grouping of modes does not match what is now done in #46308

[cmsbuild]

Pull request has been put on hold by @Dr15Jones
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[Dr15Jones]

superseded