[14_1_X] Update ZdcSimpleRecAlgo_Run3.cc

[matt2275]

PR description:

This is backport of PR #46295 for CMSSW_14_1_X

Fixed an issue where if statement checking wrong variable to guard against seg fault. Fixed issue by updating associated for loop condition to be less than digi_size. I also updated the ChargeWeightedTime to check for potential NAN which will now be set to -99.0

This issue is not critical for 2024 HI data taking. The issue was noticed when running on outdated conditions where the signal Timeslices included 6 which caused the bad if statement to skip the calculation of the ChargeWeightedTime variable since the number of samples in the digi is 6. When the conditions are updated for the signal TS to be 2 and the noise TS to be 1, the if statement will be false and ChargeWeightedTime will be calculated correctly. The for loop will be unchanged since nTS_ = digi_size = 6. There is a small risk of seg fault if nTS_ is updated in ZdcHitReconstructorRun3 to be greater than the digi_size but that would not occur on global reconstructor, only local running if the user happens to update that value incorrectly.

PR validation:

For testing, I ran on this script where previously, the values of the ChargeWeightedTime were NAN and now are positive floats from 0 to 125 ns.

[cmsbuild]

A new Pull Request was created by @matt2275 for CMSSW_14_1_X.

It involves the following packages:

• RecoLocalCalo/HcalRecAlgos (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @abdoulline, @apsallid, @argiro, @bsunanda, @mariadalfonso, @missirol, @rchatter, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[jfernan2]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6aa2cb/42041/summary.html
COMMIT: f787df2
CMSSW: CMSSW_14_1_X_2024-10-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46296/42041/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 54 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331166
• DQMHistoTests: Total failures: 3679
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327467
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

backport of PR #46295

[mandrenguyen]

+1