Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating phase2_realistic to point to 141X_mcRun4_realistic_v2 #46264

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

BenjaminRS
Copy link
Contributor

PR description:

This PR updates the GT pointed to by phase2_realistic, from 141X_mcRun4_realistic_v1 to 141X_mcRun4_realistic_v2. This follows the new GT created yesterday.

PR validation:

When running the L1TrackNtupleMaker over Spring24 samples and re-running the track trigger: previously (with 141X_mcRun4_realistic_v1) we would get an error of type:
Size mismatch between geometry (size=43600) and alignments (size=43708)
After switching to 141X_mcRun4_realistic_v2, there is no error, and we can run over the files again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46264/42087

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

A new Pull Request was created by @BenjaminRS for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

srimanob commented Oct 4, 2024

@cmsbuild please test

@srimanob
Copy link
Contributor

srimanob commented Oct 4, 2024

Do we need to update GT in old release, 14_1_X, 14_0_X?

@mmusich
Copy link
Contributor

mmusich commented Oct 4, 2024

just for record, you could change this line

process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:phase2_realistic', '')

to use auto:phase2_realistic_T33 and that would work (note that I don't disagree with the PR by itself)

@mmusich
Copy link
Contributor

mmusich commented Oct 4, 2024

Do we need to update GT in old release, 14_1_X, 14_0_X?

yes, that would be commendable.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7da7a2/41976/summary.html
COMMIT: 36c9f34
CMSSW: CMSSW_14_2_X_2024-10-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46264/41976/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331336
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3331313
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Oct 6, 2024

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f727e25 into cms-sw:master Oct 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants