-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TPSAlgorithm #46243
Improve TPSAlgorithm #46243
Conversation
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46243/42063 |
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@aloeliger, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
Initialize member data in match_t Add const where applicable Improve copying elements to a vector
d0b577f
to
d6c7d6a
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46243/42067 |
Pull request #46243 was updated. @aloeliger, @cmsbuild, @epalencia can you please check and sign again. |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
@cms-sw/l1-l2 ping |
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
Code compiles.