Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TPSAlgorithm #46243

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Improve TPSAlgorithm #46243

merged 1 commit into from
Oct 10, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Initialize member data in match_t. This was spotted by UBSAN.
  • Add const where applicable
  • Improve copying elements to a vector

PR validation:

Code compiles.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • L1Trigger/Phase2L1GMT (l1)

@aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be7691/41938/summary.html
COMMIT: d0b577f
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46243/41938/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

Initialize member data in match_t
Add const where applicable
Improve copying elements to a vector
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

Pull request #46243 was updated. @aloeliger, @cmsbuild, @epalencia can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be7691/41950/summary.html
COMMIT: d6c7d6a
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46243/41950/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 2023.0010012023.001001_RunDisplacedJet2023C_10k/step1_dasquery.log
  • 2023.1000012023.100001_RunMuonEG2023D_10k/step1_dasquery.log
  • 2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
Expand to see more relval errors ...
  • 2023.001001
  • 2023.100001
  • 2024.001001

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be7691/42016/summary.html
COMMIT: d6c7d6a
CMSSW: CMSSW_14_2_X_2024-10-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46243/42016/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@Dr15Jones
Copy link
Contributor Author

@cms-sw/l1-l2 ping

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9668a4d into cms-sw:master Oct 10, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the fixTPSAlgorithm branch November 11, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants