Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD Validation: speed up LocalRecoValidation plus other fixes #46236

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

rdelliga
Copy link
Contributor

@rdelliga rdelliga commented Oct 3, 2024

PR description:
This PR sets as optional cluster resolution histograms using SIM hits associated to the cluster as mtd truth (instead of MtdSimLayerClusters), in ETL and BTL LocalRecoValidation.
With this update, a reduced time consumption is achieved (tested with TimeMemorySummary on TTbarPU):

  • btlLocalRecoValid, from ~1.34s to ~0.05s
  • etlLocalRecoValid, from ~18.83s to ~0.05s
    Furthermore, ExtraPtEff and ExtraPtEtl2Eff histogram range were updated in MtdTracksHarvester.cc (to fix an issue introduced with PR Track selection update in MTD Validation #45457) and mtdHarvesting_cfg.py was moved to D110 scenario.
    Finally, some unused parameters were removed from MtdTracksValidation.cc and vertex time resolution ranges and binning were updated.

PR validation:
The updated validation code has been tested in the CMSSW_14_2_0_pre1 release with the workflows:

  • 29634.0_TTbar_14TeV+2026D110
  • 29834.0_TTbar_14TeV+2026D110PU
    The new code produces histograms compatible to the current validation.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

A new Pull Request was created by @rdelliga for master.

It involves the following packages:

  • Validation/MtdValidation (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Oct 3, 2024

type mtd

@cmsbuild cmsbuild added the mtd label Oct 3, 2024
@fabiocos
Copy link
Contributor

fabiocos commented Oct 3, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

+1

Size: This PR adds an extra 72KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b9e81/41923/summary.html
COMMIT: 9e5c681
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46236/41923/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 130 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331066
  • DQMHistoTests: Total failures: 4679
  • DQMHistoTests: Total nulls: 14
  • DQMHistoTests: Total successes: 3326353
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -86.45400000000001 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 24834.911,... ): -7.841 KiB MTD/BTL
  • DQMHistoSizes: changed ( 24834.911,... ): -7.186 KiB MTD/ETL
  • DQMHistoSizes: changed ( 24834.911,... ): 0.344 KiB MTD/Tracks
  • DQMHistoSizes: changed ( 24834.911,... ): 0.273 KiB MTD/Vertices
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 45cc131 into cms-sw:master Oct 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants