-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD Validation: speed up LocalRecoValidation plus other fixes #46236
Conversation
…vester.cc, mtdHarvesting_cfg.py moved to D110 scenario
…tead of MtdSimLayerClusters in ETL and BTL LocalRecoValidation set as optional
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46236/42051 |
A new Pull Request was created by @rdelliga for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type mtd |
please test |
+1 Size: This PR adds an extra 72KB to repository Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR sets as optional cluster resolution histograms using SIM hits associated to the cluster as mtd truth (instead of MtdSimLayerClusters), in ETL and BTL LocalRecoValidation.
With this update, a reduced time consumption is achieved (tested with TimeMemorySummary on TTbarPU):
Furthermore, ExtraPtEff and ExtraPtEtl2Eff histogram range were updated in MtdTracksHarvester.cc (to fix an issue introduced with PR Track selection update in MTD Validation #45457) and mtdHarvesting_cfg.py was moved to D110 scenario.
Finally, some unused parameters were removed from MtdTracksValidation.cc and vertex time resolution ranges and binning were updated.
PR validation:
The updated validation code has been tested in the CMSSW_14_2_0_pre1 release with the workflows:
The new code produces histograms compatible to the current validation.