Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HLT Phase2 timing script. #46185

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Oct 1, 2024

PR description:

This should fix the script and profit of the new features added to the underlying benchmark script.

PR validation:

Successfully tested locally.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

cms-bot internal usage

@rovere
Copy link
Contributor Author

rovere commented Oct 1, 2024

enable hlt_p2_timing

@rovere
Copy link
Contributor Author

rovere commented Oct 1, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

A new Pull Request was created by @rovere for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor Author

rovere commented Oct 1, 2024

FYI @mmusich @VourMa

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-814400/41848/summary.html
COMMIT: c7a0617
CMSSW: CMSSW_14_2_X_2024-10-01-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46185/41848/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Oct 1, 2024

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Oct 1, 2024

+hlt

  • HLT P2 Timing chart is now available

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants