Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQM] Fix syntax in python scripts #46166

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

Fix syntax in python scripts:

  • Switch to python 3 syntax: print(), except ... as
  • Partial fix for indentation: make all indented line use the same characters for indentation (either spaces or tabs), remove mixing of tabs and spaces
  • Add missing braces and commas, fix invalid syntax (FWLiteEnabler::enable() should be ROOT.FWLiteEnabler.enable()), remove trailing semicolons
  • Replaced (potentially unsafe) exec with import_module

This is a preparation for fixing #46113 . Maybe some of these scripts are not needed anymore and can be removed?

PR validation:

Bot tests.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46166/41964

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • DPGAnalysis/HcalTools (dqm)
  • DQM/SiTrackerPhase2 (dqm)
  • DQMOffline/CalibCalo (dqm)
  • DQMOffline/Configuration (dqm)
  • HLTriggerOffline/Btag (dqm)
  • Validation/CaloTowers (dqm)
  • Validation/HcalHits (dqm)
  • Validation/MuonGEMHits (dqm)
  • Validation/RecoMuon (dqm)
  • Validation/RecoTrack (dqm)
  • Validation/RecoVertex (dqm)

@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@AlexDeMoor, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @JanFSchulte, @Ming-Yan, @ReyerBand, @Senphy, @VinInn, @VourMa, @abbiendi, @abdoulline, @andrea21z, @andrzejnovak, @arossi83, @bsunanda, @calderona, @castaned, @cericeci, @demuller, @dgulhan, @felicepantaleo, @hatakeyamak, @jhgoh, @jshlee, @missirol, @mmusich, @mtosi, @rociovilar, @rovere, @sroychow, @thomreis, @threus, @trocino, @venturia, @wang0jin, @watson-ij, @wmtford this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please abort

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2024

+1

Size: This PR adds an extra 92KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd64cb/41830/summary.html
COMMIT: 3439026
CMSSW: CMSSW_14_2_X_2024-09-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46166/41830/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b42e3a9 into cms-sw:master Oct 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants