Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HCAL-DQM] New plot BadQualityEvents vs all LS and changes of alarm threshold for CapID and BadQEvents for CMSSW_14_1_X #46157

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[HCAL-DQM] New plot BadQualityEvents vs all LS and changes of alarm threshold for CapID and BadQEvents for CMSSW_14_1_X #46157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61fb364
Thresholds changed from 1 to 0.994 for BadQ and BadCapID
Sep 30, 2024
e1b7c3b
Adding new BadQEvents plot for all LS
Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions DQM/HcalTasks/data/HcalQualityTests.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@

<QTEST name="BadCapIDThreshold">
<TYPE>ContentsWithinExpected</TYPE>
<PARAM name="error">1.0</PARAM>
<PARAM name="warning">1.0</PARAM>
<PARAM name="error">0.994</PARAM>
<PARAM name="warning">0.994</PARAM>
<PARAM name="minMean">-1.0</PARAM>
<PARAM name="maxMean">0.0</PARAM>
<PARAM name="minRMS">0.0</PARAM>
Expand All @@ -32,8 +32,8 @@
</LINK>
<QTEST name="BadQualityThreshold">
<TYPE>ContentsWithinExpected</TYPE>
<PARAM name="error">1.0</PARAM>
<PARAM name="warning">1.0</PARAM>
<PARAM name="error">0.994</PARAM>
<PARAM name="warning">0.994</PARAM>
<PARAM name="minMean">-1.0</PARAM>
<PARAM name="maxMean">0.0</PARAM>
<PARAM name="minRMS">0.0</PARAM>
Expand Down
1 change: 1 addition & 0 deletions DQM/HcalTasks/interface/RawTask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ class RawTask : public hcaldqm::DQTask {
hcaldqm::Container2D _cSummaryvsLS_FED; // online only
hcaldqm::ContainerSingle2D _cSummaryvsLS; // online only
hcaldqm::ContainerSingle2D _cBadQ_FEDvsLSmod10; // online only
hcaldqm::ContainerSingle2D _cBadQ_FEDvsLS; // online only
};

#endif
26 changes: 18 additions & 8 deletions DQM/HcalTasks/plugins/RawTask.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,12 @@ RawTask::RawTask(edm::ParameterSet const& ps)
new hcaldqm::quantity::FEDQuantity(vFEDs),
new hcaldqm::quantity::ValueQuantity(hcaldqm::quantity::fState),
0);
_cBadQ_FEDvsLS.initialize(_name,
"BadQ_FEDvsLS",
new hcaldqm::quantity::LumiSectionCoarse(_maxLS, 10),
new hcaldqm::quantity::FEDQuantity(vFEDs),
new hcaldqm::quantity::ValueQuantity(hcaldqm::quantity::fN),
0);
_cBadQ_FEDvsLSmod10.initialize(_name,
"BadQ_FEDvsLSmod10",
new hcaldqm::quantity::LumiSection(10),
Expand Down Expand Up @@ -174,6 +180,7 @@ RawTask::RawTask(edm::ParameterSet const& ps)
_cSummaryvsLS_FED.book(ib, _emap, _subsystem);
_cSummaryvsLS.book(ib, _subsystem);
_cBadQ_FEDvsLSmod10.book(ib, _subsystem);
_cBadQ_FEDvsLS.book(ib, _subsystem);
_cDataSizevsLS_FED.book(ib, _emap, _subsystem);
}

Expand Down Expand Up @@ -226,12 +233,19 @@ RawTask::RawTask(edm::ParameterSet const& ps)
return;
}

if (_ptype == fOnline && lumiCache->EvtCntLS == 1) { // Reset the bin for _cBadQ_FEDvsLSmod10 at the beginning of each new LS
for (std::vector<uint32_t>::const_iterator it = _vhashFEDs.begin(); it != _vhashFEDs.end(); ++it) {
HcalElectronicsId eid = HcalElectronicsId(*it);
_cBadQ_FEDvsLSmod10.setBinContent(eid, _currentLS % 10, 0);
}
}
int nn = 0;
// loop thru and fill the detIds with bad quality
// NOTE: Calibration Channels are skipped!
// TODO: Include for Online Calibration Channels marked as bad
// a comment below is left on purpose!
//_cBadQualityvsBX.fill(bx, creport->badQualityDigis());

int Nbadq = creport->badQualityDigis();
if (lumiCache->EvtCntLS == 1)
_NBadQEvent = 0; // Reset at the beginning of each new LS
Expand Down Expand Up @@ -416,8 +430,6 @@ std::shared_ptr<hcaldqm::Cache> RawTask::globalBeginLuminosityBlock(edm::Luminos
for (uint32_t iflag = 0; iflag < _vflags.size(); iflag++)
_cSummaryvsLS_FED.setBinContent(eid, _currentLS, int(iflag), int(flag::fNCDAQ));
_cSummaryvsLS.setBinContent(eid, _currentLS, int(flag::fNCDAQ));
if (!hcaldqm::utilities::isFEDHO(eid) && fed != 1136)
_cBadQ_FEDvsLSmod10.setBinContent(eid, _currentLS % 10, int(flag::fNCDAQ));
continue;
}

Expand All @@ -437,12 +449,8 @@ std::shared_ptr<hcaldqm::Cache> RawTask::globalBeginLuminosityBlock(edm::Luminos
_vflags[fOrnMsm]._state = flag::fGOOD;
if (double(_xBadQLS.get(eid)) > double(12 * _evsPerLS))
_vflags[fBadQ]._state = flag::fBAD;
//else if (_xBadQLS.get(eid) > 0){
// Following line added due to https://gitlab.cern.ch/cmshcal/docs/-/issues/233
// BadQ > (5%) of number of events in this LS.
else if (double(_xBadQLS.get(eid)) > 0 && double(_NBadQEvent) > double(0.05 * _evsPerLS)) {
else if (_xBadQLS.get(eid) > 0){
_vflags[fBadQ]._state = flag::fPROBLEMATIC;

} else
_vflags[fBadQ]._state = flag::fGOOD;
}
Expand All @@ -454,9 +462,11 @@ std::shared_ptr<hcaldqm::Cache> RawTask::globalBeginLuminosityBlock(edm::Luminos
for (std::vector<flag::Flag>::iterator ft = _vflags.begin(); ft != _vflags.end(); ++ft) {
_cSummaryvsLS_FED.setBinContent(eid, _currentLS, int(iflag), ft->_state);

if (ft->_name == "BadQ") {
// Following line added due to https://gitlab.cern.ch/cmshcal/docs/-/issues/233 // BadQ > (5%) of number of events in this LS.
if (ft->_name == "BadQ" && (double(_xBadQLS.get(eid)) > 0 && double(_NBadQEvent) > double(0.05 * _evsPerLS))) {
if (!hcaldqm::utilities::isFEDHO(eid) && fed != 1136 && ft->_state != 3) {
_cBadQ_FEDvsLSmod10.setBinContent(eid, _currentLS % 10, (double(_NBadQEvent) / double(_evsPerLS)) * 100);
_cBadQ_FEDvsLS.setBinContent(eid, _currentLS, (double(_NBadQEvent) / double(_evsPerLS)) * 100);
}
}
fSum += (*ft);
Expand Down