-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usePCACleaning to CLUE3DHighStep_cff and fix HFNose seeded region #46152
Add usePCACleaning to CLUE3DHighStep_cff and fix HFNose seeded region #46152
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46152/41944 |
A new Pull Request was created by @Moanwar for master. It involves the following packages:
@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
type bug-fix |
@cmsbuild, please test |
+1 Size: This PR adds an extra 20KB to repository Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR updates the HFNose module in PatternRecognitionbyCA to protect it from events without seeding regions and adds usePCACleaning to CLUE3DHighStep_cff.
It fixes the issue found in PR #45821 and should be tested with D115, workflow 32034.0.
Tagging @felicepantaleo @waredjeb @hatakeyamak