Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 14_1_X (1/N) [14_2_X] #46139

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 27, 2024

PR description:

Development of HLT menus for CMSSW_14_1_X (branch CMSSW_14_2_X):

  • This is the PR for the master branch, which will then be backported down to 14_1_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This update includes the integration of the following changes (094abc7):

  • migration of the combined HLT table and related subtables to the CMSSW_14_1_0 confDB template;
  • removal of now useless customization functions related to CMSSW_14_1_X developments;

PR validation:

TSG Integration tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_14_1_X.

This update includes the integration of the following changes:
- migration of the combined HLT table and related subtables to CMSSW_14_1_0
- removal of now useless customization functions related to CMSSW_14_1_X developments
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 27, 2024

type hlt-integration

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 27, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Sep 27, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 936KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2db93/41787/summary.html
COMMIT: 094abc7
CMSSW: CMSSW_14_2_X_2024-09-27-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46139/41787/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 102 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331332
  • DQMHistoTests: Total failures: 3234
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328078
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.007 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): -0.001 KiB HLT/Filters
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53015
  • DQMHistoTests: Total failures: 810
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52205
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: found differences in 1 / 6 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Sep 29, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2c234d6 into cms-sw:master Sep 29, 2024
14 checks passed
@mmusich mmusich deleted the HLTdevelopment141X_for142X branch September 30, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants