-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix minimum of the di-muon mass window in the Z->mm validation tool #46134
Conversation
type bug-fix |
cms-bot internal usage |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46134/41923 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@atpathak, @consuegs, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
It was recently noticed by @TomasKello that the default mass window range in the python configuration of the
ZMuMu
validation tool was in the range [80-120] GeV.Restricting the mass fits in this asymmetric region around the Z mass peak ends up biasing the output fit parameters, as illustrated e.g. this plot:
This in turn created some unphysical features in the distribution of the invariant mass peak position as a function of the muon kinematic that are used to validate the various alignments.
The goal of this PR is to allow the fit to cover the whole region [60-120] GeV as default value in the all-in-one tool configuration, as already done in the
fillDescriptions
method of the plugin, see:cmssw/Alignment/OfflineValidation/plugins/DiMuonValidation.cc
Lines 380 to 381 in 3914bc8
PR validation:
The tool was run in the vanilla release and the newly proposed defaults.
as it can be seen unphysical bin by bin oscillations are removed.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported town to
CMSSW_14_0_X
.