Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 14_0_X (11/N) [14_1_X] #46130

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 26, 2024

backport of #46129

PR description:

Development of HLT menus for CMSSW_14_0_X (branch CMSSW_14_1_X): this is the close-out PR for HLT development in the CMSSW_14_0_X cycle.

  • This is the PR for the CMSSW_14_1_X branch, which will then be backported down to 14_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).
  • These updates correspond to the changes accumulated in the 14_0_X release cycle after the "V1.4" (last) menu for the 2024 pp data-taking period was released, and target the 2024 HIon and PRef data-taking as well as the first pp menu for 2025.

This update includes the integration of the following JIRA tickets:

  • CMSHLT-3335 [TSG/HIon] Clean-up HIon subtable from unused L1T seeds for 2024 data-taking

In addition, the following changes are included:

PR validation:

TSG Integration tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #46129 to the 2024 HIon production cycle (CMSSW_14_1_X)

These updates correspond to the changes accumulated in the 14_0_X release cycle after the "V1.4" (last) menu for the 2024 pp data-taking period was released.
This update includes the integration of the following JIRA tickets:

- [CMSHLT-3335](https://its.cern.ch/jira/browse/CMSHLT-3335) [TSG/HIon] Clean-up HIon subtable from unused L1T seeds for 2024 data-taking
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 26, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 26, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 26, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 780KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edc4e8/41761/summary.html
COMMIT: 3013117
CMSSW: CMSSW_14_1_X_2024-09-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46130/41761/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331159
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3331131
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Sep 26, 2024

type hlt-integration

@mmusich
Copy link
Contributor Author

mmusich commented Sep 26, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Sep 27, 2024

@cms-sw/orp-l2 please merge this, we'll need shortly to push more changes to ease integration of more HIon and PRef tickets

@mmusich
Copy link
Contributor Author

mmusich commented Sep 27, 2024

urgent

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b3b7186 into cms-sw:CMSSW_14_1_X Sep 27, 2024
9 checks passed
@mmusich mmusich deleted the HLTdevelopment140X_for141X branch September 28, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants