Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous PrimaryVertexMonitor updates #46101

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 23, 2024

PR description:

Title says it all:

  • add IP Pull plots (useful when validating alignment errors);
  • add fillDescriptions to PrimaryVertexMonitor
  • general clean-up (const correctness of data-members)

PR validation:

Privately checked runTheMatrix.py -l 140.063 -t 4 -j 8 --ibeos output.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, could be backported for 2024 data-taking purposes

- add IP Pull plots
- add fillDescriptions to PrimaryVertexMonitor
- general clean-up
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQMOffline/RecoB (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @demuller, @rociovilar this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 23, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-167db5/41709/summary.html
COMMIT: 70990ac
CMSSW: CMSSW_14_2_X_2024-09-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46101/41709/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 2023.0010012023.001001_RunDisplacedJet2023C_10k/step1_dasquery.log
  • 2023.1000012023.100001_RunMuonEG2023D_10k/step1_dasquery.log
  • 2023.1010012023.101001_RunDisplacedJet2023D_10k/step1_dasquery.log
Expand to see more relval errors ...
  • 2024.100001
  • 2023.001001
  • 2023.100001
  • 2023.101001
  • 2024.100001

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 19 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3437782
  • DQMHistoTests: Total failures: 2008
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3435754
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 121.00500000000011 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 12434.7,... ): 1.715 KiB OfflinePV/Alignment
  • DQMHistoSizes: changed ( 12834.0,... ): 5.430 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 24834.911,... ): 3.590 KiB HLT/Vertexing
  • Checked 197 log files, 168 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Sep 23, 2024

ignore tests-rejected external-failure

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cb70def into cms-sw:master Sep 25, 2024
10 of 11 checks passed
@mmusich mmusich deleted the mm_dev_addIP_pull_simple branch September 25, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants