Run3-hcx363 Bug fix to HcalTopologyMode to enable understanding new modes

[bsunanda]

PR description:

Bug fix to HcalTopologyMode to enable understanding new modes. Needed to prepare 2024 Geometry payloads. Urgent

PR validation:

Tested with payload preparation

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backported to 14_1_X in #46078

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46077/41867

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

• Geometry/HcalCommonData (geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[mandrenguyen]

@bsunanda do I understand correctly that I should wait for the back port of this PR before building 14_1_0?

[bsunanda]

Please do that. I have already requested the backport. I shall sign it immediately. Thanks for this

…

________________________________ From: Matthew Nguyen ***@***.***> Sent: 20 September 2024 21:42 To: cms-sw/cmssw ***@***.***> Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***> Subject: Re: [cms-sw/cmssw] Run3-hcx363 Bug fix to HcalTopologyMode to enable understanding new modes (PR #46077) @bsunanda<https://github.com/bsunanda> do I understand correctly that I should wait for the back port of this PR before building 14_1_0? — Reply to this email directly, view it on GitHub<#46077 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOR4VUKIOYWPE3BPMILZXRCOFAVCNFSM6AAAAABOSKQPOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRUGA3TANJXHE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[bsunanda]

+geometry

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e4a12/41672/summary.html
COMMIT: a8b2933
CMSSW: CMSSW_14_2_X_2024-09-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46077/41672/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
• 2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log
• 2024.001001DAS Error

Expand to see more relval errors ...

• 2024.100001

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 95 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331158
• DQMHistoTests: Total failures: 3241
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327897
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

ignore tests-rejected with ib-failure

[mandrenguyen]

+1