-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce era modifier run3_nanoAOD_pre142X #46066
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46066/41856
|
enable nano |
A new Pull Request was created by @hqucms for master. It involves the following packages:
@AdrianoDee, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @ftorrresd, @hqucms, @kskovpen, @mandrenguyen, @miquork, @rappoccio, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 32KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 Could you please review and sign? We have a few PRs pending on this to be merged first. |
+Upgrade |
A gentle ping @cms-sw/pdmv-l2 @cms-sw/operations-l2 -- this is blocking #46112 and a few more developments in the pipeline for NanoAOD v15. Thanks! |
Hi @hqucms dummy question. While I understand the need of the new modifier, I don't understand why it becomes the default one for the current cycle NANO wfs right?. Shouldn't it be differentiated (as is done for the other cycles)? |
Hi @AdrianoDee -- It's not the default if the MINI input is also produced in the current (14_2_X) cycle. It's only for reading MiniAODs from previous cycles , eg. 140X for 2024, 130X for 2022/2023, etc. |
+pdmv |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR introduces a new era modifier,
run3_nanoAOD_pre142X
, for running the NANO step from pre-14_2_X Run3 MiniAODs (e.g., 13_0_X and 14_0_X). This will allow for developments that move some sequences/products from the NANO step to the MINI step.This resolves #46038.
PR validation:
runTheMatrix.py -w nano --ibeos -l 2500.101,2500.111,2500.201,2500.211