Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 14_0_X (10/N) [14_2_X] #46048

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 19, 2024

PR description:

Development of HLT menus for CMSSW_14_0_X (branch CMSSW_14_2_X).

  • This is the PR for the master branch, which will then be backported down to 14_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).
  • These updates correspond to the changes accumulated in the 14_0_X release cycle after the "V1.4" (last) menu for the 2024 pp data-taking period was released, and target the 2024 HIon and PRef data-taking as well as the first pp menu for 2025.

This update includes the integration of the following JIRA tickets:

  • CMSHLT-3296 [TSG] Remove unused Paths of the Special table
  • CMSHLT-3298 [TSG] Remove suppression of warnings and errors from HLT MessageLogger for hltOnlineBeamSpot
  • CMSHLT-3303 [EXO] Add missing hltIter2MergedForDisplaced from HLTMonitor event content
  • CMSHLT-3310 [TSG] Update to 2024 eras in TSG tests
  • CMSHLT-3306 [HIon/DQM] Review of HIDQM EventContent (HI Run 2024)
  • CMSHLT-3307 [BRIL] Update "LumiScan" offline menu (post Run2024G)
  • CMSHLT-3329 [Egamma/PF] Fix mismatch of EB and EE recHits in supercluster producer modules
  • CMSHLT-3284 [HIon/TRK] Move to Pixel-Alpaka modules in the HIon menu
  • CMSHLT-3309 [DQM] Update DeltaR matching cut for hltPixelTracksSoACompareGPUvsCPU and hltSiPixelTracksSoACompareGPUvsCPUPPOnAA
  • CMSHLT-3323 [HIon] Muon Triggers for pp Reference Run 2024
  • CMSHLT-3332 [DQM] Fix inconsistent module labels for HLTDQMPixelReconstruction vs HLTDQMPixelReconstructionPPOnAA

In addition, the following changes are included:

  • 5b0df29: update of L1T PRef menu in TSG GTs to L1Menu_CollisionsPPRef2024_v0_0_2_xml
  • c171eb2: remove customizeHLTforAlpaka.py file from 14.2.X branch

PR validation:

TSG Integration tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_14_0_X.

These updates correspond to the changes accumulated in the 14_0_X release cycle after the "V1.4" (last) menu for the 2024 pp data-taking period was released.
This update includes the integration of the following JIRA tickets:

- [CMSHLT-3296](https://its.cern.ch/jira/browse/CMSHLT-3296) [TSG] Remove unused Paths of the Special table
- [CMSHLT-3298](https://its.cern.ch/jira/browse/CMSHLT-3298) [TSG] Remove suppression of warnings and errors from HLT MessageLogger for hltOnlineBeamSpot
- [CMSHLT-3303](https://its.cern.ch/jira/browse/CMSHLT-3303) [EXO] Add missing hltIter2MergedForDisplaced from HLTMonitor event content
- [CMSHLT-3310](https://its.cern.ch/jira/browse/CMSHLT-3310) [TSG] Update to 2024 eras in TSG tests
- [CMSHLT-3306](https://its.cern.ch/jira/browse/CMSHLT-3306) [HIon/DQM] Review of HIDQM EventContent (HI Run 2024)
- [CMSHLT-3307](https://its.cern.ch/jira/browse/CMSHLT-3307) [BRIL] Update "LumiScan" offline menu (post Run2024G)
- [CMSHLT-3329](https://its.cern.ch/jira/browse/CMSHLT-3329) [Egamma/PF]  Fix mismatch of EB and EE recHits in supercluster producer modules
- [CMSHLT-3284](https://its.cern.ch/jira/browse/CMSHLT-3284) [HIon/TRK] Move to Pixel-Alpaka modules in the HIon menu
- [CMSHLT-3309](https://its.cern.ch/jira/browse/CMSHLT-3309) [DQM] Update DeltaR matching cut for hltPixelTracksSoACompareGPUvsCPU and hltSiPixelTracksSoACompareGPUvsCPUPPOnAA
- [CMSHLT-3323](https://its.cern.ch/jira/browse/CMSHLT-3323) [HIon] Muon Triggers for pp Reference Run 2024
- [CMSHLT-3332](https://its.cern.ch/jira/browse/CMSHLT-3332) [DQM] Fix inconsistent module labels for HLTDQMPixelReconstruction vs HLTDQMPixelReconstructionPPOnAA
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

enable gpu

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46048 was updated. @Martin-Grunewald, @mmusich can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 792KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9828bc/41621/summary.html
COMMIT: c171eb2
CMSSW: CMSSW_14_2_X_2024-09-19-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46048/41621/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 133 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331151
  • DQMHistoTests: Total failures: 6720
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3324411
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53003
  • DQMHistoTests: Total failures: 803
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52200
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

type hlt-integration

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2024

@cms-sw/orp-l2 please consider merging this (and all its backports markded as hlt-integration). We need to move forward to integrate more tickets for the upcoming HIon run

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 640cd98 into cms-sw:master Sep 20, 2024
14 checks passed
@mmusich mmusich deleted the HLTdevelopment140X_for142X branch September 20, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants